chore: interaction model generator can now also write to standard output #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shreyas-vgr
reviewed
Sep 10, 2020
| const interactionModelJson: string = JSON.stringify(this.build(), null, 2); | ||
| const path: string = join(process.cwd(), filename); | ||
| fs.writeFileSync(path, interactionModelJson); | ||
| if (filename == null) { |
There was a problem hiding this comment.
nit: if (filename === null)
13 tasks
13 tasks
|
Added this change as part of this PR #24 to be checked in. |
13 tasks
mikelid-zz
pushed a commit
that referenced
this pull request
Feb 4, 2021
- ControlManager.handleInternalError can produce a complete response, including setting the shouldEndSession flag. - ControlHandler has three modes for handling exceptions that occur during initialization and/or canHandle. - Default - ControlManager.handleInternalError produces response - Alternative #1 - silently return canHandle=false - Alternative #2 - rethrow exception to topLevel BREAKING CHANGE: - the default behavior for an exception thrown during canHandle is changed. Revert to the old behavior by setting ControlHandler.canHandleThrowBehavior = 'Rethrow'
13 tasks
mikelid-zz
pushed a commit
that referenced
this pull request
Feb 4, 2021
- ControlManager.handleInternalError can produce a complete response, including setting the shouldEndSession flag. - ControlHandler has three modes for handling exceptions that occur during initialization and/or canHandle. - Default - ControlManager.handleInternalError produces response - Alternative #1 - silently return canHandle=false - Alternative #2 - rethrow exception to topLevel BREAKING CHANGE: - the default behavior for an exception thrown during canHandle is changed. Revert to the old behavior by setting ControlHandler.canHandleThrowBehavior = 'Rethrow'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If no filename parameter is passed to function buildAndWrite in InteractionModelGenerator.ts then the built model is sent to standard output
Motivation and Context
This change allows to make build time scripts that regenerate and fully overwrite the model even more concise. Going for example from this:
"prepublish": "node build_interaction_model.js && mv en-US-generated.json ../skill-package/interactionModels/custom/en-US.json"to this:
"prepublish": "node build_interaction_model.js > ../skill-package/interactionModels/custom/en-US.json"Testing
When through the standard build and test procedure in the project including husky, commitlint and passing all the battery of included tests
Screenshots (if appropriate)
Types of changes
Checklist
License