Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ns completions for cljc-files #90

Closed
eval opened this issue Jun 15, 2023 · 2 comments · Fixed by #91
Closed

ns completions for cljc-files #90

eval opened this issue Jun 15, 2023 · 2 comments · Fixed by #91
Labels
enhancement

Comments

@eval
Copy link
Contributor

eval commented Jun 15, 2023

It seems that cljc files are not considered by compliment.utils/namespaces-on-classpath.

Hence the namespace malli.core is not offered as a completion in the following example:

$ clojure -Sdeps '{:deps {org.clojure/clojure {:mvn/version "RELEASE"} metosin/malli {:mvn/version "RELEASE"} compliment/compliment {:mvn/version "RELEASE"}}}' \
          -M -e '(prn ((requiring-resolve (quote compliment.core/completions)) "malli."))'
({:candidate "malli.dev", :type :namespace} {:candidate "malli.instrument", :type :namespace} {:candidate "malli.instrument.cljs", :type :namespace})

Let me know what you think and I'll submit a PR!
@alexander-yakushev
Copy link
Owner

Hello Gert! Thank you for pointing this out and for an exhaustive reproducer! I'll be more than glad to take a PR from you that fixes this.

@eval eval mentioned this issue Jun 15, 2023
Merged
@eval
Copy link
Contributor Author

eval commented Jun 15, 2023

Hi Alexander, thanks for quick reply! Opened #91.

eval added a commit to eval/compliment that referenced this issue Jun 16, 2023
@eval
namespaces-on-classpath yields also cljc candidates
587dd71 
...and introduce namespaces&files-on-classpath to allow for filtering on
cljs files.

Fixes alexander-yakushev#90
eval added a commit to eval/compliment that referenced this issue Jun 16, 2023
@eval
namespaces-on-classpath yields also cljc candidates
f277568 
...and introduce namespaces&files-on-classpath that yields collection of
maps with e.g. :file.

Fixes alexander-yakushev#90
eval added a commit to eval/compliment that referenced this issue Jun 17, 2023
@eval
namespaces-on-classpath yields also cljc candidates
e5d31fa 
...and introduce namespaces&files-on-classpath that yields collection of
maps with e.g. :file.

Fixes alexander-yakushev#90
eval added a commit to eval/compliment that referenced this issue Jun 17, 2023
@eval
namespaces-on-classpath yields also cljc candidates
f4cab7a 
...and introduce namespaces&files-on-classpath that yields collection of
maps with e.g. :file.

Fixes alexander-yakushev#90
eval added a commit to eval/compliment that referenced this issue Jun 17, 2023
@eval
namespaces-on-classpath yields also cljc candidates
2b02083 
...and introduce namespaces&files-on-classpath that yields collection of
maps with e.g. :file.

Fixes alexander-yakushev#90
alexander-yakushev pushed a commit that referenced this issue Jun 17, 2023
@eval @alexander-yakushev
namespaces-on-classpath yields also cljc candidates
55d992c 
...and introduce namespaces&files-on-classpath that yields collection of
maps with e.g. :file.

Fixes #90
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Also consider cljc files for namespaces-on-classpath eval/compliment
2 participants
@eval @alexander-yakushev