Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot add a function to query from typeahead #468

Closed
1 of 3 tasks
zaben903 opened this issue Oct 23, 2017 · 5 comments
Closed
1 of 3 tasks

Cannot add a function to query from typeahead #468

zaben903 opened this issue Oct 23, 2017 · 5 comments

Comments

@zaben903
Copy link

I'm submitting a ...

  • Bug report
  • Feature requestdd
  • Question / Support request

Software Versions

Grafana Zabbix Grafana-Zabbix Plugin
4.5.2 3.2.3 3.6.1

What did you do?

Attempt to add a function to a dashboard

What was the expected result?

function (eg rate() ) is added to query mode for an item

What happened instead?

The function removes itself and the following error is created:

TypeError: $scope.addFunction is not a function
    at eval (add-metric-function.directive.js:48)
    at o.$eval (boot.e4836696.js:61)
    at o.$apply (boot.e4836696.js:61)
    at b.updater (add-metric-function.directive.js:47)
    at b.select (boot.e4836696.js:8)
    at b.click (boot.e4836696.js:8)
    at HTMLUListElement.e (boot.e4836696.js:56)
    at HTMLUListElement.dispatch (boot.e4836696.js:57)
    at HTMLUListElement.q.handle (boot.e4836696.js:57)
(anonymous) @ boot.e4836696.js:60

Conditions where it was created:

B - Query Mode: Metrics
Group: someGroup
Host: someHost
Application: someApplication
Item: SomeItem
Functions: (ATTEMPTING TO PUT rate() FUNCTION HERE)

@alexanderzobnin
Copy link
Collaborator

Looks strange. How did you install plugin? Try to clear browser cache.

@zaben903
Copy link
Author

The plugin was installed following the cli install step (In the README). Tested with cache disabled (including different devices) and problem still persists.

Update to the issue:
Grafana version: 4.6.2
Grafana-zabbix plugin: 3.7.0

@zaben903
Copy link
Author

zaben903 commented Jan 4, 2018

The specific method to reproduce is to start to type for a function (such as rate) and select from the drop-down. This fails.

The method I have tried which I am using as a workaround is to not type but to go through the drop-down menu manually to select the function to use.

This is checked again using grafana-zabbix plugin version 3.8.1

@alexanderzobnin
Copy link
Collaborator

Yes, confirmed. Thanks for the clarification.

@chriskuipers
Copy link

Hi! Any updates on this bug? We're having the same issues. We're running Grafana 6.1.6, Zabbix 3.0.22 and the 3.10.2 plugin version.

@alexanderzobnin alexanderzobnin changed the title Cannot add a function to query Cannot add a function to query from typeahead Dec 26, 2019
@alexanderzobnin alexanderzobnin added this to the 3.10.5 milestone Dec 26, 2019
alexanderzobnin added a commit that referenced this issue Jan 15, 2020
* CI: fix shellcheck issues (#789)

Signed-off-by: Mario Trangoni <mjtrangoni@gmail.com>

* annotations: fix options in grafana 6.x, fix #813

* fix function editor in Grafana 6.4, closes #810

* add typings for grafana packages

* Add $__range_series variable for calculating function over the whole series, #531

* fix tests

* Don't set alert styles for react panels, fix #823

* docs: add range variables

* docs: percentile reference

* fix codespell

* update packages (build with node 12)

* update circleci node image to 12

* fix test configuration (babel)

* Fix 817 (#851)

* problems: update panel schema

* update packages (build with node 12)

* problems: use datasource from target

* problems: fix query editor after schema update

* problems: fix list layout

* update circleci node image to 12

* fix tests

* build(deps-dev): bump lodash from 4.17.10 to 4.17.13 (#852)

Bumps [lodash](https://github.com/lodash/lodash) from 4.17.10 to 4.17.13.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](lodash/lodash@4.17.10...4.17.13)

Signed-off-by: dependabot[bot] <support@github.com>

* fix packages security alerts

* problems: fix tags adding and removal

* fix adding func from typeahead, closes #468

* update change log

* bump plugin version to 3.10.5

* problems: fix tag removal (list layout)

* Fix percentile() function, closes #862 (#863)

Like the other aggregation functions, the datapoints need to be sorted in
time before calling groupBy_perf().

* Update copyright, happy New Year!

* fix not acknowledged problem color with a message (#858)

* fix not acknowledged problem color with a message

* fix not acknowledged problem color with a message, closes #857

* Variable query editor (#856)

* refactor: convert module to typescript

* refactor: covert utils to typescript

* variable query editor WIP

* variable editor: fix type error after grafana/ui update

* variable editor: use FormLabel from grafana/ui

* variable editor: refactor

* variable editor: input validation and highlights

* variable editor: fix tests

* variable query: fix backward compatibility with empty queries

* fix linter errors

* variable editor: fix variable replacement in queries

* Fixes for backend

Co-authored-by: Mario Trangoni <mario@mariotrangoni.de>
Co-authored-by: Alexander Zobnin <alexanderzobnin@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Mark Reibert <mreibert@netskope.com>
Co-authored-by: memfiz <arnis.civciss@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants