Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

function editor is not working #810

Closed
dataniard opened this issue Oct 5, 2019 · 6 comments
Closed

function editor is not working #810

dataniard opened this issue Oct 5, 2019 · 6 comments
Labels
comp: functions type/bug
Milestone
3.10.5

Comments

@dataniard
Copy link

Function editor is not working in 6.4.1. Nor Function Label neither buttons appears.

grafana 6.4.1
plugin 3.10.4
imagen

It worked on previous versions
grafana 6.3.5
plugin 3.10.4
imagen

Grafana Zabbix Grafana-Zabbix Plugin
6.4.1 4.0.1 3.10.4
@loganobrien
Copy link

Experiencing the same issue on Grafana v6.4.2 (commit: 443a0ba) with Plugin v3.10.4.

@alexanderzobnin
Copy link
Collaborator

Yes, this is Grafana 6.4-related only thing. Investigating and preparing a fix.

@alexanderzobnin alexanderzobnin added this to the 3.11 milestone Oct 9, 2019
@papagian papagian mentioned this issue Oct 15, 2019
Closed
@Q-nu Q-nu mentioned this issue Oct 16, 2019
Closed
@guyhom
Copy link

guyhom commented Oct 16, 2019

Hello, Thank you for having this bug fixed !
Do you think you can release the 2 debugs (this one, #810, and also #813 about annotations) in a hotfix release before 3.11 ?
It would be very helpful in my case, we use extensively these functions in our Grafana instances, and I must admit not being able to edit them is quite uncomfortable at the moment.

@alexanderzobnin
Copy link
Collaborator

@guyhom I will try to prepare release in next few weeks. I won't make patch release because I have few features implemented, but I will rather rearrange milestone.

@maxlehot1234
Copy link

Anything on this? @alexanderzobnin Almost 3 weeks now ;P :)

@mammuthus
Copy link
Contributor

Still looking forward to it :)

@alexanderzobnin alexanderzobnin modified the milestones: 3.11, 3.10.5 Dec 25, 2019
alexanderzobnin added a commit that referenced this issue Dec 30, 2019
@vignesh-reddy @mjtrangoni @alexanderzobnin
Backend: Merge master into the backend branch (#845)
c300deb 
* CI: fix shellcheck issues (#789)

Signed-off-by: Mario Trangoni <mjtrangoni@gmail.com>

* annotations: fix options in grafana 6.x, fix #813

* fix function editor in Grafana 6.4, closes #810

* add typings for grafana packages

* Add $__range_series variable for calculating function over the whole series, #531

* fix tests

* Don't set alert styles for react panels, fix #823

* docs: add range variables

* docs: percentile reference

* fix codespell

Co-authored-by: Mario Trangoni <mario@mariotrangoni.de>
Co-authored-by: Alexander Zobnin <alexanderzobnin@gmail.com>
@alecxvs alecxvs mentioned this issue Jan 8, 2020
Closed
alexanderzobnin added a commit that referenced this issue Jan 15, 2020
@alecxvs @mjtrangoni
@alexanderzobnin @dependabot @mr-ns @memfiz
[Backend] Merge 'master' changes into the backend (#875)
92e7761 
* CI: fix shellcheck issues (#789)

Signed-off-by: Mario Trangoni <mjtrangoni@gmail.com>

* annotations: fix options in grafana 6.x, fix #813

* fix function editor in Grafana 6.4, closes #810

* add typings for grafana packages

* Add $__range_series variable for calculating function over the whole series, #531

* fix tests

* Don't set alert styles for react panels, fix #823

* docs: add range variables

* docs: percentile reference

* fix codespell

* update packages (build with node 12)

* update circleci node image to 12

* fix test configuration (babel)

* Fix 817 (#851)

* problems: update panel schema

* update packages (build with node 12)

* problems: use datasource from target

* problems: fix query editor after schema update

* problems: fix list layout

* update circleci node image to 12

* fix tests

* build(deps-dev): bump lodash from 4.17.10 to 4.17.13 (#852)

Bumps [lodash](https://github.com/lodash/lodash) from 4.17.10 to 4.17.13.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](lodash/lodash@4.17.10...4.17.13)

Signed-off-by: dependabot[bot] <support@github.com>

* fix packages security alerts

* problems: fix tags adding and removal

* fix adding func from typeahead, closes #468

* update change log

* bump plugin version to 3.10.5

* problems: fix tag removal (list layout)

* Fix percentile() function, closes #862 (#863)

Like the other aggregation functions, the datapoints need to be sorted in
time before calling groupBy_perf().

* Update copyright, happy New Year!

* fix not acknowledged problem color with a message (#858)

* fix not acknowledged problem color with a message

* fix not acknowledged problem color with a message, closes #857

* Variable query editor (#856)

* refactor: convert module to typescript

* refactor: covert utils to typescript

* variable query editor WIP

* variable editor: fix type error after grafana/ui update

* variable editor: use FormLabel from grafana/ui

* variable editor: refactor

* variable editor: input validation and highlights

* variable editor: fix tests

* variable query: fix backward compatibility with empty queries

* fix linter errors

* variable editor: fix variable replacement in queries

* Fixes for backend

Co-authored-by: Mario Trangoni <mario@mariotrangoni.de>
Co-authored-by: Alexander Zobnin <alexanderzobnin@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Mark Reibert <mreibert@netskope.com>
Co-authored-by: memfiz <arnis.civciss@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp: functions type/bug
Projects
None yet
Milestone
3.10.5
Development

No branches or pull requests
6 participants
@mammuthus @alexanderzobnin @maxlehot1234 @guyhom @loganobrien @dataniard