Merge pull request #12 from alexandreh2ag/update_http_server_panic

Prevent panic when http server stop
alexandreh2ag · Jan 25, 2025 · 67f97b2 · 67f97b2
2 parents e3379ca + 049074d
commit 67f97b2
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/apps/agent/http/server.go b/apps/agent/http/server.go
@@ -1,12 +1,14 @@
 package http
 
 import (
+	"fmt"
 	"github.com/alexandreh2ag/lets-go-tls/apps/agent/context"
 	"github.com/alexandreh2ag/lets-go-tls/apps/agent/http/controller"
 	"github.com/alexandreh2ag/lets-go-tls/apps/agent/http/middleware"
 	"github.com/alexandreh2ag/lets-go-tls/http"
 	"github.com/labstack/echo-contrib/echoprometheus"
 	"github.com/labstack/echo/v4"
+	buildinHttp "net/http"
 )
 
 func CreateServerHTTP(ctx *context.AgentContext) (*echo.Echo, error) {
@@ -25,7 +27,9 @@ func CreateServerHTTP(ctx *context.AgentContext) (*echo.Echo, error) {
 
 	go func() {
 		err := e.Start(ctx.Config.HTTP.Listen)
-		ctx.Logger.Error(err.Error())
+		if err != nil && err != buildinHttp.ErrServerClosed {
+			panic(fmt.Errorf("fail to start http server with %v", err))
+		}
 
 	}()
 	return e, nil

diff --git a/apps/server/http/server.go b/apps/server/http/server.go
@@ -10,6 +10,7 @@ import (
 	"github.com/labstack/echo-contrib/echoprometheus"
 	echojwt "github.com/labstack/echo-jwt/v4"
 	"github.com/labstack/echo/v4"
+	buildinHttp "net/http"
 )
 
 const (
@@ -47,7 +48,7 @@ func CreateServerHTTP(ctx *context.ServerContext, httpProvider *acmeHttp.Challen
 		} else {
 			err = e.Start(ctx.Config.HTTP.Listen)
 		}
-		if err != nil {
+		if err != nil && err != buildinHttp.ErrServerClosed {
 			panic(fmt.Errorf("fail to start http server with %v", err))
 		}
 	}()