Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump sbt-scoverage version #80

Merged
merged 3 commits into from
Oct 17, 2016
Merged

Conversation

alexarchambault
Copy link
Owner

@alexarchambault alexarchambault commented Oct 11, 2016

Running

$ sbt ++2.10.6 coverage test coverageReport

on the current master actually compiles the project in 2.11 :-(

That effectively made the 2.10 CI build compile the project in 2.11. Bad news: 2.10 is broken :-|

Former one seemed to switch the scala version to 2.11
@alexarchambault alexarchambault force-pushed the topic/travis-scala-2.10 branch from c68be99 to 13364e4 Compare October 11, 2016 08:58
@alexarchambault alexarchambault changed the title Remove (s)coverage support Bump sbt-scoverage version Oct 11, 2016
now that we're in 1.2
As it doesn't compile out-of-the box in 2.10. It can be re-instated in
the default source folder when dropping support for 2.10.
@codecov-io
Copy link

codecov-io commented Oct 16, 2016

Current coverage is 80.13% (diff: 100%)

Merging #80 into master will increase coverage by 0.77%

@@             master        #80   diff @@
==========================================
  Files             8          8          
  Lines           155        151     -4   
  Methods         150        145     -5   
  Messages          0          0          
  Branches          5          6     +1   
==========================================
- Hits            123        121     -2   
+ Misses           32         30     -2   
  Partials          0          0          

Powered by Codecov. Last update 4e17fde...afd0248

@alexarchambault
Copy link
Owner Author

@reactormonk I took the liberty to only compile the JsonCodec macro in 2.11 here, as it doesn't compile as is in 2.10 (which couldn't be detected by the CI until this PR :-| ). If you feel like adding or need support for it in 2.10, feel free to send a PR for it.

@alexarchambault alexarchambault merged commit 2f8999a into master Oct 17, 2016
@alexarchambault alexarchambault deleted the topic/travis-scala-2.10 branch August 11, 2022 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants