New singleton implementation that removes all statics #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexchuber
force-pushed
the
draco-compression-no-statics
branch
from
0a2680a to
ce32f9d
Compare
alexchuber
force-pushed
the
draco-compression-no-statics
branch
from
ce32f9d to
5e66a45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An idea for enforcing singleton pattern w/o using statics
Export the singleton at the module level. Do not export the class.
To export this singleton without the heavy overhead of the old constructor, separate it into a new
initializemethod that users must call. This has the nice side effect of forcing users to be intentional with the lifecycle management of a DracoDecoder.In case the singleton pattern is a Mistake, we can always go back and expose the class to users?
All of this is based on the idea that a module-level singleton is even a good idea... TBD?