Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

visjs and visjs-community #45

Open
pleek91 opened this issue Mar 20, 2019 · 20 comments
Open

visjs and visjs-community #45

pleek91 opened this issue Mar 20, 2019 · 20 comments

Comments

@pleek91
Copy link

pleek91 commented Mar 20, 2019

The main visjs has been end of life'd in favor of individual repositories for the individual features.

Here's the post about it.
almende/vis#4259

Looks like the network and timeline have been broken out into their own modules.
https://github.com/visjs-community

Considering the main visjs repository is no longer being updated. It would be great to update vue2vis to use these new modules as they become available. I'd be willing to work on the timeline component. But I'd like to know if @alexcode is open to moving forward with this before I start working on it.

Thanks

@alexcode
Copy link
Owner

Thanks for the heads-up @pleek91. I haven't spend time on this project recently but I will still invest although mainly on the timeline as well. I agree with you that if we want to benefit from the vis.js development going forward, we need to use the new modules.

This raise the question of having only one repo/npm module. Should we breakdown this repo as well or importing all the vis-community into this one ?

On a side note, I'm not sure the community modules are ready yet.

@Menighin what do you think ?

Thanks
Alex

@pleek91
Copy link
Author

pleek91 commented Mar 26, 2019

@alexcode I like the idea of having multiple repos following the direction that the vis-community repo is going. Also, the timeline-plus module has been actively developed for a while. That one might be ready to use. Not sure about the others.

@Menighin
Copy link
Contributor

Hi guys,

I agree on splitting vue2vis into modules, following Vis direction.
I have been busy lately as well but will help on the Network asap (dunno if the Vis module for network is ready as well).

@alexcode
Copy link
Owner

@micahstubbs
Copy link

hello 👋 visjs-network maintainer here.

I'm happy to help update to vue2vis to use visjs-network for network visualization if that is something that interests you all.

the API of https://www.npmjs.com/package/visjs-network is backwards compatible with the legacy https://www.npmjs.com/package/vis mono-library.

we follow semver in visjs-network, so that backwards compatibility will be maintained at least until the next major version of visjs-network

@pleek91
Copy link
Author

pleek91 commented Mar 28, 2019

@yotamberk is this something you would be willing to help with?

@yotamberk
Copy link

I will be moving to vis-community in the next few weeks.
Until then you are welcome to use my fork:
https://github.com/yotamberk/timeline-plus

@pleek91
Copy link
Author

pleek91 commented Apr 25, 2019

Looks like timeline-plus has been moved into vis-community.

@yotamberk
Copy link

Not an updated version. Still working on my own fork. I will move there eventually

@r3code
Copy link

r3code commented Sep 4, 2019

@Menighin @alexcode @pleek91 @yotamberk @micahstubbs This week I created vue-vis-network based on the vue2vis. It contains only https://github.com/visjs/vis-network.
Should I publish it at NPM?

@havardthom
Copy link

Hi, is anyone working on a vue wrapper for the vis-community timeline repo? https://github.com/visjs/vis-timeline

@alexcode
Copy link
Owner

Well, I'm not sure if we should go the multi-repo way as visJs does. It make sense from their perspective but as wrapper I feel that we maybe better of the monorepo way with Lerna.
As we reuse the same boilerplate and utils, the bug fixes/features/upgrade would benefit the whole wrapper but still be split in lightweight NPM packages with a monorepo.
What do you think ?

@r3code
Copy link

r3code commented Sep 11, 2019

If you think so. You should organize a base repo structure.
Meantime I thank you for your work - it give me the base for rapid adaptation of new visjs to vue.

Well, I'm not sure if we should go the multi-repo way as visJs does. It make sense from their perspective but as wrapper I feel that we maybe better of the monorepo way with Lerna.
As we reuse the same boilerplate and utils, the bug fixes/features/upgrade would benefit the whole wrapper but still be split in lightweight NPM packages with a monorepo.
What do you think ?

@micahstubbs
Copy link

@r3code thanks for asking, I would say that's a decision for you and your user community 😄

For upstream library authoring, splitting into multiple repos is nice, because it lets maintainers focus on the part of the library that they really care about. If you and your fellow maintainers care about all of the parts of vue2vis, then I think the monorepo approach with Lerna that @alexcode suggests sounds reasonable.

@meshy
Copy link

meshy commented Feb 21, 2020

@r3code thanks for making the fork. If you published your fork to NPM, I'm sure I wouldn't be the only one to use and appreciate it.

@r3code
Copy link

r3code commented Feb 22, 2020

@meshy Ok. I'll publish as soon as possible. You are not the first who asked me to publish, so I think I should do it.

@meshy
Copy link

meshy commented Feb 22, 2020

@r3code thank you -- don't hurry just for me though -- I'm happy for you to take your time :)

@r3code
Copy link

r3code commented Feb 22, 2020

@meshy I'll publish in 48 hours. I Had published once but forgot to generate dist which I need to create jsfiddle demo

@meshy
Copy link

meshy commented Feb 22, 2020

Honestly, there's no rush -- I think I've found a good enough work-around for my use-case now anyway. Still -- others might find it useful!

@r3code
Copy link

r3code commented Feb 24, 2020

@meshy Published https://www.npmjs.com/package/vue-vis-network/v/1.0.1

alexcode added a commit that referenced this issue Mar 18, 2020
Refactored monorepo to feature parity with branch 0.x.

re #45, re #52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants