This repository has been archived by the owner on Jun 21, 2019. It is now read-only.
Attempt to work around rust-lang/cargo#5956 #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Work around vendoring stale contents by forcing Cargo to re-unpack all crates which we vendor. Closes #130
|
This looks reasonable to me. Hopefully this is enough to address the issues we've seen! |
cuviper
reviewed
Oct 19, 2018
|
|
||
| // First up attempt to work around rust-lang/cargo#5956. Apparently build | ||
| // artifacts sprout up in Cargo's global cache for whatever reason, although | ||
| // it's unsure what tool is causing these issues at this time. For now we |
There was a problem hiding this comment.
IIRC, semverver is one such tool that I've noticed building directly in the cache.
There was a problem hiding this comment.
Oh interesting! Do you know if there's an issue on the repo for that already to cc?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work around vendoring stale contents by forcing Cargo to re-unpack all
crates which we vendor.
Closes #130