Skip to content
This repository has been archived by the owner on Jun 21, 2019. It is now read-only.

Build source bundle including vendored dependencies #51

Merged
merged 1 commit into from
Sep 28, 2017

Conversation

bachp
Copy link
Contributor

@bachp bachp commented Sep 23, 2017

This simplifies boostrapping as one can just download the bundle
including all dependencies.

Closes #50

@bachp
Copy link
Contributor Author

bachp commented Sep 23, 2017

Not sure how to test this

@bachp bachp changed the title Build source bundle including vendored dependencies WIP:Build source bundle including vendored dependencies Sep 23, 2017
@bachp bachp changed the title WIP:Build source bundle including vendored dependencies Build source bundle including vendored dependencies Sep 23, 2017
@bachp
Copy link
Contributor Author

bachp commented Sep 23, 2017

Ok I was able to test it: https://github.com/bachp/cargo-vendor/releases

@alexcrichton
Copy link
Owner

It looks like this creates a tarball for just the dependencies? Perhaps this could create a tarball for the source code itself?

@bachp
Copy link
Contributor Author

bachp commented Sep 23, 2017

@alexcrichton No it actually creates a tarball including the sources + a vendor folder.

  • git archive is used to get a clean source tree
  • the build cargo vendor binary is used to fetch the vendor directory which is then copied into the new tarball
  • the resulting folder is then put into the tarball

@alexcrichton
Copy link
Owner

Could this just produce one tarball with all source code necessary? I feel like that's what a "standard source tarball" generally looks like...

@bachp
Copy link
Contributor Author

bachp commented Sep 24, 2017

@alexcrichton I'm not sure what you mean with "all source code necessary". The tarball contains the cargo-vendor source code as found on github plus the vendored depenencies in a vendor directory. You can have a look at my example here.

Do you expect it to contain more? Or is there some more source code that I'm missing?

@alexcrichton
Copy link
Owner

Hm I think I may have read the wrong version of the patch... in any case sorry this looks great! Could the tarball be called cargo-vendor-src-$TAG.tar.gz perhaps?

This simplifies boostrapping as one can just download the bundle
including all dependencies.

Closes alexcrichton#50
@bachp
Copy link
Contributor Author

bachp commented Sep 27, 2017

Done

Example will appear here once the build is complete

@alexcrichton alexcrichton merged commit 63362b1 into alexcrichton:master Sep 28, 2017
@alexcrichton
Copy link
Owner

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants