Link against clang runtime on static builds on macOS #283
Conversation
|
Nice! This is a bit simpler than I thought it would be. Two requests for an update:
|
badboy
force-pushed
the
fix-static-link-on-macos
branch
from
d1d903f to
eb35c01
Compare
|
@alexcrichton Could you please share the logs of failed checks or trigger a rebuild on github actions by amending the commit (with no changes) and force pushing that? I'd like to take a look, but unfortunately, it looks like I don't have access to them. |
badboy
force-pushed
the
fix-static-link-on-macos
branch
from
eb35c01 to
62116be
Compare
On OSX we need to link against the clang runtime, which is hidden in some non-default path. We can get the path from `clang --print-search-dirs`. Kudos to @ehuss for finding that workaround. Fixes alexcrichton#279.
badboy
force-pushed
the
fix-static-link-on-macos
branch
from
62116be to
31a058f
Compare
|
Rebased and force-pushed /cc @dmitmel |
|
Well, it looks like there are no errors now. I can confirm that this PR indeed fixes #279 on my machine with macOS 10.13. |
|
Seems reasonable! |
I'd like to pull in #283 downstream so that I can close sagebind/isahc#68. Master has everything needed now, I just need a new version...
Update features set in CI. This removes the `curl/force-system-lib-on-osx` feature, which I don't think has been needed for a while (I believe it was fixed with alexcrichton/curl-rust#283). This also uses the same features for `test -p cargo-test-support` so that cargo doesn't get recompiled (saving about a minute).
* fix(ios): link clang_rt.ios to include isPlatformVersionAtLeast See alexcrichton/curl-rust#283 * lint [skip ci] * update swift-rs to 1.0.2
On OSX we need to link against the clang runtime, which is hidden in some non-default path.
We can get the path from
clang --print-search-dirs.Kudos to @ehuss for finding that workaround.
Fixes #279.