Upgrade project to edition 2018 #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weihanglo
commented
May 3, 2021
curl-sys/lib.rs
Outdated
Comment on lines
4
to
14
| extern crate libc; | ||
| // These `extern crate` are required for conditional linkages of curl. | ||
| #[cfg(link_libnghttp2)] | ||
| extern crate libnghttp2_sys; | ||
| #[cfg(link_libz)] | ||
| extern crate libz_sys; | ||
| #[cfg(feature = "mesalink")] | ||
| extern crate mesalink; // ensure lib is linked to | ||
| #[cfg(link_openssl)] | ||
| extern crate openssl_sys; | ||
| #[cfg(windows)] | ||
| extern crate winapi; |
There was a problem hiding this comment.
Here we preserve extern crate for openssl_sys, libnghttp2_sys and libz_sys for the sake of conditional linkage.
|
Really weird. It seems that all CI tests has passed. https://github.com/alexcrichton/curl-rust/actions/runs/805297756 |
alexcrichton
reviewed
May 3, 2021
| #[cfg(link_libnghttp2)] | ||
| extern crate libnghttp2_sys; | ||
| #[cfg(link_libz)] | ||
| extern crate libz_sys; | ||
| #[cfg(feature = "mesalink")] | ||
| extern crate mesalink; // ensure lib is linked to |
There was a problem hiding this comment.
I think this needs to remain for the linkage too?
There was a problem hiding this comment.
Probably not? I thought it would be linked automatically when feature "mesalink" is on. Anyway, updated at 5768b0b.
|
Thanks for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just update to edition 2018 before edition 2021 coming.