Expose the CURLOPT_HTTP09_ALLOWED libcurl option #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagebind
reviewed
May 5, 2022
src/easy/handle.rs
Outdated
| @@ -1280,6 +1280,11 @@ impl Easy { | |||
| self.inner.pipewait(wait) | |||
| } | |||
|
|
|||
| /// Same as [`Easy2::http_09`](struct.Easy2.html#method.http_09) | |||
| pub fn http_09(&mut self, allow: bool) -> Result<(), Error> { | |||
There was a problem hiding this comment.
Nit: I might name this http_09_allowed which would more closely match the libcurl option name.
|
Thanks! The implementation looks correct to me, just some minor suggestions. |
jbangelo
force-pushed
the
curlopt_http09_allowed
branch
from
45bf250 to
7fab850
Compare
|
@sagebind I've updated the method names as you suggested. Thanks for the quick feedback! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses my feature request in #436. It adds the ability to set the
CURLOPT_HTTP09_ALLOWEDoption. Unfortunately there are still use cases for this option.I took my best guess as to how to properly implement it. Please let me know if there's anything that needs to be changed, or even if exposing this option is acceptable.