Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to some include files being rearranged in more recent versions of curl, the
sys/time.h
header was no longer being included fortimeval.c
, which was causing the error:This fixes it by setting HAVE_SYS_TIME_H which would normally be set by the configure script.
I don't actually know why gcc treats this as a warning, and clang treats it as an error.
Details:
curl_setup.h
used to includecurl.h
which always importssys/time.h
. However, curl/curl@e5839f4 removed thecurl.h
import. The only waysys/time.h
gets imported otherwise is incurl_setup_once.h
, but that is conditional on HAVE_SYS_TIME_H.