Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
libssh2_knownhost_addc()
expectscomment
to be a C string: it copiescommentlen + 1
bytes internally from the buffer pointed bycomment
pointer. Granted, this is misleading: one would expect that if a function takes a pointer and length of data, it wouldn't access memory past this limit.Passing a
&str
as a pointer and its length is incorrect and results in segmentation fault withrustc
> 1.78.0 on macOS 14.6.1 (23G93) and FreeBSD 14 - we pass empty &str literal to the function.