Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Windows CI #300

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix Windows CI #300

wants to merge 3 commits into from

Conversation

ncihnegn
Copy link
Contributor

@ncihnegn ncihnegn commented Aug 22, 2022 •
edited
Loading

To fix #299.

@alexcrichton
Copy link
Owner

Personally I don't want to get in to the business of interpreting paths too much since it's already tricky enough. Stripping a leading // already feels quite dubious. Is there perhaps a way to fix the test or otherwise test for a different result on Windows? Or use different Path APIs on Windows?

@ncihnegn
Copy link
Contributor Author

Are you open to use a crate for UnixPath?

@alexcrichton
Copy link
Owner

I'm not personally familiar with any such crates, is there no way to do this using the standard library?

@ncihnegn
Copy link
Contributor Author

ncihnegn commented Sep 2, 2022

I think using UnixPath is the cleanest way.
See rust-lang/rust#100833.

@ncihnegn ncihnegn force-pushed the windows branch 2 times, most recently from 80bc06f to c0ffc46 Compare September 12, 2022 08:55
@ncihnegn
Copy link
Contributor Author

Simplified a bit without using a crate; please review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Windows CI is failing due to std::path::Path
2 participants
@ncihnegn @alexcrichton