Upgrade xz to 5.4.1 #108
Closed
Upgrade xz to 5.4.1 #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
- Update path to `xz` source code
- Ignores test files:
- good-1-arm64-lzma2-1.xz
- good-1-arm64-lzma2-2.xz
- good-1-empty-bcj-lzma2.xz
Since the first two uses ARM64 filter and the last one has an empty
Block that uses PowerPC BCJ and LZMA2 that seems to break on my M1.
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
NobodyXu
commented
Jan 27, 2023
Comment on lines
+33
to
+40
| // Ignores `good-1-arm64-lzma2-1.xz` and `good-1-arm64-lzma2-2.xz` | ||
| // since they uses the ARM64 filter. | ||
| // | ||
| // Ignores `good-1-empty-bcj-lzma2.xz` since it has an empty Block | ||
| // that uses PowerPC BCJ and LZMA2. | ||
| if filename.contains("arm64") || filename == "good-1-empty-bcj-lzma2.xz" { | ||
| continue; | ||
| } |
There was a problem hiding this comment.
I have no idea why these tests failed on my M1.
Disabling them fixed the CI, but not sure this is the right thing to do.
There was a problem hiding this comment.
Aha I see this is because arm encoder is not enabled, which will be fixed by #111
|
From what I can tell, the malicious actor started contributing to XZ back in 2020. 5.2.5 looks like the last stable version before that point, so it might be worth holding off on any updates until some clarity is brought to the whole situation. |
|
Agreed, closing the PR for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jiahao XU Jiahao_XU@outlook.com