This repository has been archived by the owner on Aug 20, 2021. It is now read-only.
Readme update + quick fix for file_get_contents #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now use curl instead. Obvilusly better implimented as a utility function/class. Works for now though
|
Thanks for the PR! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some other changes were thrown in for the readme, but those were just my editor removing left over white space which I think is fine to just accept.
Readme update is specific for linux, as you need to allow the web server user access to the cache directory to write the json files in.
file_get_contentsisn't the best way to get files on a remote server, plus it doesn't seem to run that well at times. Curl is generally a better practice for PHP when obtaining remote files via HTTP or HTTPS protocols.