Skip to content

Commit

Permalink
fix(jasmine): enforce that jasmine_node_test is loaded from new location
Browse files Browse the repository at this point in the history
BREAKING CHANGE:
You can no longer get jasmine_node_test from @build_bazel_rules_nodejs.
- Use `load("@npm_bazel_jasmine//:index.bzl", "jasmine_node_test")`
instead
- You need to remove `@npm//jasmine` from the deps of the
jasmine_node_test
- If you use user-managed dependencies, see the commit for examples of
the change needed

Also makes the repo bazel-lint-clean, so running yarn bazel:lint-fix no
longer makes edits.

Fixes bazel-contrib#838
  • Loading branch information
alexeagle committed Jul 27, 2019
1 parent 432f88c commit bb36162
Show file tree
Hide file tree
Showing 75 changed files with 2,711 additions and 897 deletions.
1 change: 0 additions & 1 deletion BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ bzl_library(
deps = [
"//internal/history-server:bzl",
"//internal/http-server:bzl",
"//internal/jasmine_node_test:bzl",
"//internal/npm_package:bzl",
"//internal/rollup:bzl",
"//toolchains/node:bzl",
Expand Down
1 change: 0 additions & 1 deletion docs/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ skylark_doc(
"//internal/common:check_bazel_version.bzl",
"//internal/history-server:history_server.bzl",
"//internal/http-server:http_server.bzl",
"//internal/jasmine_node_test:jasmine_node_test.bzl",
"//internal/node:node.bzl",
"//internal/node:node_repositories.bzl",
"//internal/npm_install:npm_install.bzl",
Expand Down
6 changes: 0 additions & 6 deletions docs/common/check_bazel_version.html
Original file line number Diff line number Diff line change
Expand Up @@ -48,12 +48,6 @@
<ul>
</ul>
</li>
<li>
<a href="/rules_nodejs/jasmine_node_test/jasmine_node_test.html">NodeJS testing</a>
<ul>
<li><a href="/rules_nodejs/jasmine_node_test/jasmine_node_test.html#overview">Overview</a></li>
</ul>
</li>
<li>
<a href="/rules_nodejs/node/node.html">Executing programs</a>
<ul>
Expand Down
6 changes: 0 additions & 6 deletions docs/history-server/history_server.html
Original file line number Diff line number Diff line change
Expand Up @@ -48,12 +48,6 @@
<ul>
</ul>
</li>
<li>
<a href="/rules_nodejs/jasmine_node_test/jasmine_node_test.html">NodeJS testing</a>
<ul>
<li><a href="/rules_nodejs/jasmine_node_test/jasmine_node_test.html#overview">Overview</a></li>
</ul>
</li>
<li>
<a href="/rules_nodejs/node/node.html">Executing programs</a>
<ul>
Expand Down
6 changes: 0 additions & 6 deletions docs/http-server/http_server.html
Original file line number Diff line number Diff line change
Expand Up @@ -48,12 +48,6 @@
<ul>
</ul>
</li>
<li>
<a href="/rules_nodejs/jasmine_node_test/jasmine_node_test.html">NodeJS testing</a>
<ul>
<li><a href="/rules_nodejs/jasmine_node_test/jasmine_node_test.html#overview">Overview</a></li>
</ul>
</li>
<li>
<a href="/rules_nodejs/node/node.html">Executing programs</a>
<ul>
Expand Down
29 changes: 0 additions & 29 deletions docs/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -48,12 +48,6 @@
<ul>
</ul>
</li>
<li>
<a href="/rules_nodejs/jasmine_node_test/jasmine_node_test.html">NodeJS testing</a>
<ul>
<li><a href="/rules_nodejs/jasmine_node_test/jasmine_node_test.html#overview">Overview</a></li>
</ul>
</li>
<li>
<a href="/rules_nodejs/node/node.html">Executing programs</a>
<ul>
Expand Down Expand Up @@ -120,7 +114,6 @@ <h2>Rule sets</h2>
<li><a href="#check_bazel_version">Check Bazel version</a></li>
<li><a href="#history_server">Run history-server</a></li>
<li><a href="#http_server">Run http-server</a></li>
<li><a href="#jasmine_node_test">NodeJS testing</a></li>
<li><a href="#node">Executing programs</a></li>
<li><a href="#node_repositories">Install NodeJS & Yarn</a></li>
<li><a href="#npm_install">Install npm packages</a></li>
Expand Down Expand Up @@ -206,28 +199,6 @@ <h3>Macros</h3>
</tr>
</tbody>
</table>
<h2><a href="/rules_nodejs/jasmine_node_test/jasmine_node_test.html" id="jasmine_node_test">NodeJS testing</a></h2>

<h3>Macros</h3>
<table class="overview-table">
<colgroup>
<col class="col-name" />
<col class="col-description" />
</colgroup>
<tbody>
<tr>
<td>
<a href="/rules_nodejs/jasmine_node_test/jasmine_node_test.html#jasmine_node_test">
<code>jasmine_node_test</code>
</a>
</td>
<td>
<p>Runs tests in NodeJS using the Jasmine test runner.</p>

</td>
</tr>
</tbody>
</table>
<h2><a href="/rules_nodejs/node/node.html" id="node">Executing programs</a></h2>

<h3>Rules</h3>
Expand Down
213 changes: 0 additions & 213 deletions docs/jasmine_node_test/jasmine_node_test.html

This file was deleted.

6 changes: 0 additions & 6 deletions docs/node/node.html
Original file line number Diff line number Diff line change
Expand Up @@ -48,12 +48,6 @@
<ul>
</ul>
</li>
<li>
<a href="/rules_nodejs/jasmine_node_test/jasmine_node_test.html">NodeJS testing</a>
<ul>
<li><a href="/rules_nodejs/jasmine_node_test/jasmine_node_test.html#overview">Overview</a></li>
</ul>
</li>
<li>
<a href="/rules_nodejs/node/node.html">Executing programs</a>
<ul>
Expand Down
6 changes: 0 additions & 6 deletions docs/node/node_repositories.html
Original file line number Diff line number Diff line change
Expand Up @@ -48,12 +48,6 @@
<ul>
</ul>
</li>
<li>
<a href="/rules_nodejs/jasmine_node_test/jasmine_node_test.html">NodeJS testing</a>
<ul>
<li><a href="/rules_nodejs/jasmine_node_test/jasmine_node_test.html#overview">Overview</a></li>
</ul>
</li>
<li>
<a href="/rules_nodejs/node/node.html">Executing programs</a>
<ul>
Expand Down
6 changes: 0 additions & 6 deletions docs/npm_install/npm_install.html
Original file line number Diff line number Diff line change
Expand Up @@ -48,12 +48,6 @@
<ul>
</ul>
</li>
<li>
<a href="/rules_nodejs/jasmine_node_test/jasmine_node_test.html">NodeJS testing</a>
<ul>
<li><a href="/rules_nodejs/jasmine_node_test/jasmine_node_test.html#overview">Overview</a></li>
</ul>
</li>
<li>
<a href="/rules_nodejs/node/node.html">Executing programs</a>
<ul>
Expand Down
6 changes: 0 additions & 6 deletions docs/npm_package/npm_package.html
Original file line number Diff line number Diff line change
Expand Up @@ -48,12 +48,6 @@
<ul>
</ul>
</li>
<li>
<a href="/rules_nodejs/jasmine_node_test/jasmine_node_test.html">NodeJS testing</a>
<ul>
<li><a href="/rules_nodejs/jasmine_node_test/jasmine_node_test.html#overview">Overview</a></li>
</ul>
</li>
<li>
<a href="/rules_nodejs/node/node.html">Executing programs</a>
<ul>
Expand Down
6 changes: 0 additions & 6 deletions docs/rollup/rollup_bundle.html
Original file line number Diff line number Diff line change
Expand Up @@ -48,12 +48,6 @@
<ul>
</ul>
</li>
<li>
<a href="/rules_nodejs/jasmine_node_test/jasmine_node_test.html">NodeJS testing</a>
<ul>
<li><a href="/rules_nodejs/jasmine_node_test/jasmine_node_test.html#overview">Overview</a></li>
</ul>
</li>
<li>
<a href="/rules_nodejs/node/node.html">Executing programs</a>
<ul>
Expand Down
Loading

0 comments on commit bb36162

Please sign in to comment.