Move upgradeable check to using semVer/pre

The number of tag version edge cases requiring exception from being upgraded
was increasing to the point where constantly adding to the exception list was
no longer a viable approach.

This change alters how the upgradability of a tag is assessed by parsing the
current and latest tags into SemVers and then assessing the `pre` field of the
version to determine whether either of the tags are a special case.  In order
to achieve this it is necessary to move `latest` out to be a case all of itself
as this would not be nicely handled by NewVersion().

Signed-off-by: Richard Gee <richard@technologee.co.uk>

cmd/chart/upgrade.go

@@ -200,6 +200,13 @@ func updateImages(iName string, v bool) (bool, string, error) {
 
 func tagIsUpgradeable(currentTag, latestTag string) bool {
 
- return latestTag != currentTag && !strings.Contains(strings.ToLower(latestTag), "-rc") && !strings.EqualFold(currentTag, "latest")
+ if strings.EqualFold(currentTag, "latest") {
+ return false
+ }
+
+ currentSemVer, _ := semver.NewVersion(currentTag)
+ latestSemVer, _ := semver.NewVersion(latestTag)
+
+ return latestTag != currentTag && len(latestSemVer.Prerelease()) == 0 && len(currentSemVer.Prerelease()) == 0
 
 }

cmd/chart/upgrade_test.go

@@ -35,6 +35,18 @@ func Test_tagIsUpgradable(t *testing.T) {
  latest: "1.0.0-rc",
  expected: false,
  },
+ {
+ title: "current is rootless",
+ current: "1.0.0-rootless",
+ latest: "1.1.0",
+ expected: false,
+ },
+ {
+ title: "latest is rootless",
+ current: "1.0.0",
+ latest: "1.1.0-rootless",
+ expected: false,
+ },
  {
  title: "current is 'latest'",
  current: "latest",

go.mod

@@ -1,6 +1,6 @@
 module github.com/alexellis/arkade
 
-go 1.22
+go 1.22.0
 
 require (
  github.com/Masterminds/semver v1.5.0