Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore latest tags in chart upgrade #1087

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Conversation

rgee0
Copy link
Contributor

@rgee0 rgee0 commented Jun 13, 2024

Description

As described in #1086 the chart upgrade command was upgrading latest tags which was undesirable.

This change causes the upgrade command to ignore any images tagged latest.
It also addresses an edge-case around -RC tags which was highlighted by the additional test created in this change.
The k10mulitcluster tool that was disabled has also been removed, so closes #1082

Motivation and Context

How Has This Been Tested?

Functionally tested by using the faasd docker-compose.yaml.
Initially ran chart upgrade on the file as is, and one change was found:

➜  arkade git:(ignoreLatest) ✗ ./arkade chart upgrade -f faasd.yaml -v
2024/06/13 09:37:33 Verifying images in: faasd.yaml
2024/06/13 09:37:33 Found 4 images
2024/06/13 09:37:34 [ghcr.io/openfaas/gateway] 0.27.5 => 0.27.7

This image was then changed to ghcr.io/openfaas/gateway:latest and the command run again:

➜  arkade git:(ignoreLatest) ✗ ./arkade chart upgrade -f faasd.yaml -v
2024/06/13 09:37:50 Verifying images in: faasd.yaml
2024/06/13 09:37:50 Found 4 images

The new test passes as show in the pipeline

No new tool has been added.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Documentation

  • I have updated the list of tools in README.md if (required) with ./arkade get --format markdown
  • I have updated the list of apps in README.md if (required) with ./arkade install --help

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have tested this on arm, or have added code to prevent deployment

Signed-off-by: Richard Gee <richard@technologee.co.uk>
@rgee0
Copy link
Contributor Author

rgee0 commented Jun 13, 2024

I'm wondering whether it would be better to now use nextTag rather than latestTag in the pre-existing code to avoid confusion around :latest tags

Copy link
Owner

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@alexellis alexellis merged commit 0bea295 into alexellis:master Jun 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants