Fix Kubeconfig loading as per #15 #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kubeconfig flag was not honoured if set. This commit checks the flag, then os.env then the default kueconfig location. Tested by installing a handful of apps (new and old style) with and without kubeconfig flag and os.env All installed ok Signed-off-by: Alistair Hey <alistair@heyal.co.uk>
Waterdrips
force-pushed
the
waterdrips-fix-kubecofig
branch
from
3bf89fc to
5e09504
Compare
alexellis
reviewed
Oct 31, 2020
|
|
||
| if command.Flags().Changed("kubeconfig") { | ||
| kubeConfigPath, _ = command.Flags().GetString("kubeconfig") | ||
| kubeConfigPath, _ := command.Flags().GetString("kubeconfig") |
There was a problem hiding this comment.
Wonder if this could be moved into the install command?
12 tasks
nitishkumar71
added a commit
to nitishkumar71/arkade
that referenced
this pull request
Oct 31, 2020
Signed-off-by: Nitishkumar Singh <nitishkumarsingh71@gmail.com> updated code based on alexellis#258 Signed-off-by: Nitishkumar Singh <nitishkumarsingh71@gmail.com> removed additional line Signed-off-by: Nitishkumar Singh <nitishkumarsingh71@gmail.com>
nitishkumar71
added a commit
to nitishkumar71/arkade
that referenced
this pull request
Oct 31, 2020
Signed-off-by: Nitishkumar Singh <nitishkumarsingh71@gmail.com> updated code based on alexellis#258 Signed-off-by: Nitishkumar Singh <nitishkumarsingh71@gmail.com> removed additional line Signed-off-by: Nitishkumar Singh <nitishkumarsingh71@gmail.com> removed unwanted line Signed-off-by: Nitishkumar Singh <nitishkumarsingh71@gmail.com>
nitishkumar71
added a commit
to nitishkumar71/arkade
that referenced
this pull request
Nov 1, 2020
Signed-off-by: Nitishkumar Singh <nitishkumarsingh71@gmail.com> updated code based on alexellis#258 Signed-off-by: Nitishkumar Singh <nitishkumarsingh71@gmail.com> removed additional line Signed-off-by: Nitishkumar Singh <nitishkumarsingh71@gmail.com> removed unwanted line Signed-off-by: Nitishkumar Singh <nitishkumarsingh71@gmail.com> removed unwanted code Signed-off-by: Nitishkumar Singh <nitishkumarsingh71@gmail.com>
nitishkumar71
added a commit
to nitishkumar71/arkade
that referenced
this pull request
Nov 10, 2020
Signed-off-by: Nitishkumar Singh <nitishkumarsingh71@gmail.com> updated code based on alexellis#258 Signed-off-by: Nitishkumar Singh <nitishkumarsingh71@gmail.com> removed additional line Signed-off-by: Nitishkumar Singh <nitishkumarsingh71@gmail.com> removed unwanted line Signed-off-by: Nitishkumar Singh <nitishkumarsingh71@gmail.com> removed unwanted code Signed-off-by: Nitishkumar Singh <nitishkumarsingh71@gmail.com> corrected repo path Signed-off-by: Nitishkumar Singh <nitishkumarsingh71@gmail.com>
alexellis
pushed a commit
that referenced
this pull request
Nov 19, 2020
Signed-off-by: Nitishkumar Singh <nitishkumarsingh71@gmail.com> updated code based on #258 Signed-off-by: Nitishkumar Singh <nitishkumarsingh71@gmail.com> removed additional line Signed-off-by: Nitishkumar Singh <nitishkumarsingh71@gmail.com> removed unwanted line Signed-off-by: Nitishkumar Singh <nitishkumarsingh71@gmail.com> removed unwanted code Signed-off-by: Nitishkumar Singh <nitishkumarsingh71@gmail.com> corrected repo path Signed-off-by: Nitishkumar Singh <nitishkumarsingh71@gmail.com>
wilsonianb
reviewed
Dec 16, 2020
| fmt.Printf("Using kubeconfig: %s\n", kubeConfigPath) | ||
|
|
||
| os.Setenv("KUBECONFIG", kubeConfigPath) |
There was a problem hiding this comment.
If KUBECONFIG is defined but the --kubeconfig flag is not set, this appears to overwrite KUBECONFIG with nothing causing a fallback to $HOME/.kube/config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Kubeconfig flag was not honoured if set.
This commit checks the flag, then os.env then the default kueconfig
location.
Tested by installing a handful of apps (new and old style) with and
without kubeconfig flag and os.env
All installed ok
Signed-off-by: Alistair Hey alistair@heyal.co.uk
Motivation and Context
Fixes Fix --kubeconfig flag priority #15
How Has This Been Tested?
installing and building locally with various apps with and without the kubeconfig flag
Types of changes
Checklist:
git commit -s