Honour the --skip-install flag with --local

[alexellis]

Expected Behaviour

The --local flag for k3sup install doesn't honour --skip-install.

Current Behaviour

--skip-install should allow the user to get the correct kubeconfig, without doing an installation

Possible Solution

Add an if statement

Steps to Reproduce (for bugs)

1. k3sup install --local --skip-install
2. See that it still installs

[alexellis]

/add label: good first issue, help wanted

[alexellis]

Hey @Jasstkn, would you be interested in taking this on? I think it'd be a quick win for you.

[Jasstkn]

Hey @Jasstkn, would you be interested in taking this on? I think it'd be a quick win for you.

Hey! Yes, I would like to try :)

[Jasstkn]

@alexellis @Shikachuu hey. I started looking into the issue and want to reproduce it. I created a VM in GCP and trying to install k8s cluster via command:

export IP=12.34.56.78
./k3sup install --ip $IP --user mariarti --ssh-key ~/.ssh/general.pub
Error: trying to get ip value of flag of type string

But it fails with unexpected result. I'm trying to debug it but nothing useful so far. Maybe you have some suggestions where to look?

upd: if I run it will --local flag and params - it seems to be working

[alexellis]

This may be an unintentional regression in c0a4833.

[alexellis]

@Jasstkn if k3sup install --local --skip-install is actually skipping the installation of k3sup now, then I'd say we can close this issue. Interestingly, I ran the command on a Multipass Ubuntu VM where k3sup hadn't been installed and it still tried to create an empty kubeconfig for me:

k3sup install --local --skip-install
Running: k3sup install
2022/08/26 22:22:54 127.0.0.1
Skipping local installation
Saving file to: /home/ubuntu/kubeconfig

# Test your cluster with:
export KUBECONFIG=/home/ubuntu/kubeconfig
kubectl config set-context default
kubectl get node -o wide

It should probably error out instead for that scenario.

Nobody's comment on #389 yet to say that they've started working on it. There are two parts to it with the second being more involved (as per the screenshot).