Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[installer-tests] Fix GCP database config #12379

Merged
merged 1 commit into from
Sep 1, 2022
Merged

[installer-tests] Fix GCP database config #12379

merged 1 commit into from
Sep 1, 2022

Conversation

nandajavarma
Copy link
Contributor

Description

Currently the database config for GCP is buggy. The config is missing some important details and hence on nightly tests with external database as dependency, the tests fail. This PR fixes these issues. This fixes the KOTS config with the right field names and takes the output from the GKE and k3s modules to apply them respectively.

Related Issue(s)

Fixes #

How to test

werft run github -j .werft/gke-installer-tests.yaml -a skipTests=true -a deps=external
werft run github -j .werft/k3s-installer-tests.yaml -a skipTests=true -a deps=external

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview

@nandajavarma nandajavarma requested a review from a team August 25, 2022 10:41
@github-actions github-actions bot added the team: delivery Issue belongs to the self-hosted team label Aug 25, 2022
@nandajavarma nandajavarma changed the base branch from main to nvn/fix-k3s-versions August 25, 2022 10:52
Base automatically changed from nvn/fix-k3s-versions to nvn/integ-flag August 25, 2022 13:59
@adrienthebo adrienthebo self-assigned this Aug 25, 2022
@adrienthebo
Copy link
Contributor

adrienthebo commented Aug 25, 2022

Looks like europe-west1 is overloaded:

job ref

Error: ╷
│ Error: Error waiting for instance to create: The zone 'projects/sh-automated-tests/zones/europe-west1-b' does not have enough resources available to fulfill the request.  '(resource type:compute)'.
│
│
│   with module.k3s.google_compute_instance.k3s_master_instance,
│   on ../infra/modules/k3s/main.tf line 69, in resource "google_compute_instance" "k3s_master_instance":
│   69: resource "google_compute_instance" "k3s_master_instance" {
│
╵
make: *** [Makefile:127: k3s-standard-cluster] Error 1

Trying to send slack alert
tracing warning: No slice span by name create-gcp-infra

@adrienthebo
Copy link
Contributor

GKE

Looks good, setup and teardown worked job link

Rerunning k3s now.

@nandajavarma nandajavarma changed the base branch from nvn/integ-flag to main August 26, 2022 07:22
@nandajavarma nandajavarma force-pushed the nvn/fix-gcp-db branch 3 times, most recently from 31f059e to 437ea8b Compare August 26, 2022 14:51
@adrienthebo
Copy link
Contributor

k3s tests timed out and failed, re-running

@nandajavarma
Copy link
Contributor Author

@adrienthebo Doing a quick rebase with main. Just so it would pick up the tf changes in case that is what is causing this

@nandajavarma
Copy link
Contributor Author

nandajavarma commented Aug 26, 2022

Yet another failed k3s setup.. Looks like someone else using k3sup ran into the same thing. See this issue comment opened 3 hours ago. Not sure if using --local is a solution for us. Will try this maybe

@adrienthebo
Copy link
Contributor

Wow, that's a weird one, I'm surprised that this suddenly popped up out of nowhere. No rush on this though, we can tackle it on Monday :)

@alexellis
Copy link

alexellis commented Aug 26, 2022

Hi folks, if you're using k3sup for GitPodGitpod, your support would be appreciated.

The error is due to a validation change, which has since been fixed.

I'd suggest you pin the version of k3sup that you use, rather than tracking the latest binary, then upgrade it when you have time to verify newer versions.

cc @mrsimonemms

Alex

@roboquat roboquat merged commit 1117edb into main Sep 1, 2022
@roboquat roboquat deleted the nvn/fix-gcp-db branch September 1, 2022 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none size/M team: delivery Issue belongs to the self-hosted team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants