Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default backend from ingress-nginx installation #101

Merged
merged 1 commit into from
Nov 18, 2019

Conversation

aledbf
Copy link
Contributor

@aledbf aledbf commented Nov 17, 2019

Description

Default backend requirement was removed in 0.21 kubernetes/ingress-nginx#3196

Motivation and Context

Removes an unnecessary deployment

  • I have raised an issue to propose this change (required)

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@derek
Copy link

derek bot commented Nov 17, 2019

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide.
Tip: if you only have one commit so far then run: git commit --amend --signoff and then git push --force.

Signed-off-by: Manuel Alejandro de Brito Fontes <aledbf@gmail.com>
@derek derek bot removed the no-dco label Nov 17, 2019
@alexellis alexellis merged commit 5fdf568 into alexellis:master Nov 18, 2019
@alexellis
Copy link
Owner

Thanks for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants