Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring & glob update #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shybovycha
Copy link

@shybovycha shybovycha commented Jul 22, 2024

  • [BREAKING] use @actions/glob instead of glob@7.1.6 since the latter does not allow for ignore patterns as part of match patterns in paths (since the entire feature was removed in glob@6
    • this changes the format of the asset_paths input from a JSON string to a multi-line string (no quotes required)
  • code refactoring:
    • use asynchronous APIs instead of synchronous to speed things up a little bit
    • inline the entire GetRelease class into one single function
    • inline the single-use contentLength() function
  • code cleanup:
    • use constants whenever possible
    • unify the quotes for strings
    • remove dubious whitespaces
    • enforce semicolons
  • repo housekeeping:
    • add GH Actions workflow to build the action when new release is created
    • update README with reference for glob patterns and updated build instructions
    • remove unnecessary Makefile
    • enforce NodeJS version

Copy link

derek bot commented Jul 22, 2024

Thank you for your contribution. unfortunately, one or more of your commits are missing the required "Signed-off-by:" statement. Signing off is part of the Developer Certificate of Origin (DCO) which is used by this project.

Read the DCO and project contributing guide carefully, and amend your commits using the git CLI. Note that this does not require any cryptography, keys or special steps to be taken.

💡 Shall we fix this?

This will only take a few moments.

First, clone your fork and checkout this branch using the git CLI.

Next, set up your real name and email address:

git config --global user.name "Your Full Name"
git config --global user.email "you@domain.com"

Finally, run one of these commands to add the "Signed-off-by" line to your commits.

If you only have one commit so far then run: git commit --amend --signoff and then git push --force.
If you have multiple commits, watch this video.

Check that the message has been added properly by running "git log".

Add build workflow

Split code into smaller functions

Revert "Split code into smaller functions"

This reverts commit d2b9240.

Fix imports

Use raw nodejs

Remove node: prefix from imports

Split processing into two promises and use @actions/glob

Add missing module

Add failure when no artifacts are matched

Tidy up log messages

Rename function for cleaner meaning

Use for-await expression

Use glob v11

Roll back glob since it does not support ignore patterns as easily as @actions/glob

Update README

Rollback action.yml changes for contribution

Update README re. nvm

Rollback action name

Signed-off-by: Artem Shubovych <shybovycha@gmail.com>
@derek derek bot removed the no-dco label Jul 22, 2024
@shybovycha shybovycha marked this pull request as ready for review July 22, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant