Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow huge varNames #34

Closed
alexewerlof opened this issue Jun 13, 2019 · 1 comment
Closed

Don't allow huge varNames #34

alexewerlof opened this issue Jun 13, 2019 · 1 comment
Labels

Comments

@alexewerlof
Copy link
Owner

due to the risk for DDoS put a limit on how long the var names can be.
A deeply nested very long var name can potentially DDoS the user's code.
Initially the limit can be 1000 characters which using the a.b.c.d... syntax can lead to a maximum depth of 500 lookups.

@alexewerlof
Copy link
Owner Author

alexewerlof commented Jun 13, 2019

Maybe the initial limit can be lower (140 chars), but allow changing it using an option. That way the limit is not hard coded and the users can opt-in to something that makes sense to them.

alexewerlof added a commit that referenced this issue Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant