Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

group_required not working as expected #73

Closed
vieillecarne opened this issue Jan 28, 2020 · 1 comment · Fixed by #75
Closed

group_required not working as expected #73

vieillecarne opened this issue Jan 28, 2020 · 1 comment · Fixed by #75

Comments

@vieillecarne
Copy link

When the authorization failed in group_required, it should return 403 (Forbidden) and not 401.
@nickolay
Copy link

https://stackoverflow.com/questions/3297048/403-forbidden-vs-401-unauthorized-http-responses agrees and the line to be updated is https://github.com/admiralobvious/flask-simpleldap/blob/7dcddf2bf958cbf8af6d37b7a84ae52c9b9fb1db/flask_simpleldap/__init__.py#L333

@AdmiralObvious is apparently rather busy, but I've got my PRs accepted recently, so submitting one would probably increase the changes of this being fixed.

jm66 added a commit to jm66/flask-simpleldap that referenced this issue May 12, 2020
@jm66
Issue alexferl#73: group_required not working as expected
61732d1 
- fixes alexferl#73
@jm66 jm66 mentioned this issue May 12, 2020
Merged
alexferl added a commit that referenced this issue Jan 27, 2021
@alexferl
Merge pull request #75 from jm66/issue-73
9c6cb35 
Issue #73: group_required not working as expected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #73: group_required not working as expected jm66/flask-simpleldap
2 participants
@nickolay @vieillecarne