-
Notifications
You must be signed in to change notification settings - Fork 78
Add documentation for bucket sort #99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Mahi-korrapati
wants to merge
2
commits into
alexfertel:main
Choose a base branch
from
Mahi-korrapati:bucket-sort-docs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Hello! |
alexfertel
reviewed
Nov 17, 2025
src/sorting/bucket_sort.md
Outdated
Comment on lines
20
to
43
| ## Rust Example | ||
|
|
||
| ```rust | ||
| pub fn bucket_sort(arr: &mut [f32]) { | ||
| let n = arr.len(); | ||
| let mut buckets: Vec<Vec<f32>> = vec![Vec::new(); n]; | ||
|
|
||
| for &value in arr.iter() { | ||
| let index = (value * n as f32) as usize; | ||
| buckets[index.min(n - 1)].push(value); | ||
| } | ||
|
|
||
| for bucket in buckets.iter_mut() { | ||
| bucket.sort_by(|a, b| a.partial_cmp(b).unwrap()); | ||
| } | ||
|
|
||
| let mut idx = 0; | ||
| for bucket in buckets { | ||
| for value in bucket { | ||
| arr[idx] = value; | ||
| idx += 1; | ||
| } | ||
| } | ||
| } |
Owner
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove this example please.
Suggested change
| ## Rust Example | |
| ```rust | |
| pub fn bucket_sort(arr: &mut [f32]) { | |
| let n = arr.len(); | |
| let mut buckets: Vec<Vec<f32>> = vec![Vec::new(); n]; | |
| for &value in arr.iter() { | |
| let index = (value * n as f32) as usize; | |
| buckets[index.min(n - 1)].push(value); | |
| } | |
| for bucket in buckets.iter_mut() { | |
| bucket.sort_by(|a, b| a.partial_cmp(b).unwrap()); | |
| } | |
| let mut idx = 0; | |
| for bucket in buckets { | |
| for value in bucket { | |
| arr[idx] = value; | |
| idx += 1; | |
| } | |
| } | |
| } |
Owner
|
😅 you removed the whole file... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a complete and clear documentation file for the Bucket Sort algorithm.
The documentation explains the concept, steps, complexity, and provides a Rust code example aligned with the existing implementation in the repository.