Fixes getter methods created when plugins are initialized. #20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the following function definition is not wrapped in a closure
plugin
's scope is theTextExt.initPlugins
function. Because of this,on each iteration of the list of plugins to create the getter methods in
TextExt
, the return value of all created methods will be the lastvalue of
plugin
and not the value ofplugin
from when the functionwas defined for each.
Wrapping the function definition in a closure fixes this issue.
As an explicit example:
Previously, when instantiating a new
textext(...)
instance anddefining the
plugins
option asAll 3 of the following would return the
TextExtArrow
instanceAfter they closure from this changeset is applied, they return their
expected plugin instances