Fix bug with selecting and moving cursor within text input: don't setInputData unless value changed. #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using a text input rather than textarea, updating the value moves the cursor to the end of the line. Since core triggers setInputData on every keystroke, this makes it impossible to highlight, copy, paste, or move the cursor within the text. Fix by only updating the value if it has changed. I believe this also fixes the following known issue: http://github.com/alexgorbatchev/jquery-textext/issues/50
|
+1 |
|
you open the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a text input rather than textarea, updating the value moves
the cursor to the end of the line. Since core triggers setInputData on
every keystroke, this makes it impossible to highlight, copy, paste, or
move the cursor within the text.
Fix by only updating the value if it has changed.
I believe this also fixes the following known issue:
http://github.com/alexgorbatchev/jquery-textext/issues/50