-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optionally enable TLS connection #97
base: master
Are you sure you want to change the base?
Conversation
Adds the possibility to use a tls socket instead of net socket instance, if a tls connection is desired.
Reference: #40 I have tested SSL connection between client and server with this change. I can add further documentation on the usage, if this pull request gets any attention. It would be really helpful to have it merged in the main master as opposed to my fork. |
There are more work than just enabling TLS connections. In Zookeeper Java Client, the TLS connection always comes with the ability to add the client certs to the Auth data so the server can authenticated using mTLS. |
Thanks for the response. I am not sure I understand your point. In case mTLS is desired, the client cert and CA can be provided as an argument to tls.connect(). If rejectUnauthorized flag is enabled it would ensure mTLS. For such a case the opts for createClient would look something like this:
|
@alexguan Any thoughts on this? I can implement any additional functionality that you think might be missing. Would love to hear your feedback. |
@alexguan ??? |
@alexguan any news on this? |
Hi @alexguan Thank you |
Hi @alexguan |
Adds the possibility to use a tls socket instead of net socket instance,
if a tls connection is desired.