Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in the default value of dict_key_x #231

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Fix typo in the default value of dict_key_x #231

merged 1 commit into from
Aug 22, 2024

Conversation

wiseodd
Copy link
Collaborator

@wiseodd wiseodd commented Aug 21, 2024

Change the default from inputs_id to input_ids, which is the default of Huggingface.

Based on wiseodd/llm-bayesopt-exps#2

@wiseodd wiseodd added the documentation Improvements or additions to documentation label Aug 21, 2024
@wiseodd wiseodd requested review from aleximmer and runame August 21, 2024 15:16
@wiseodd wiseodd self-assigned this Aug 21, 2024
Copy link
Owner

@aleximmer aleximmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any changes to the docs that has to be reviewed or is it just because of some version change?

Copy link
Collaborator

@runame runame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question as Alex's.

@wiseodd
Copy link
Collaborator Author

wiseodd commented Aug 22, 2024

Thanks! The docs are fine --- I double-checked it.

@wiseodd wiseodd merged commit 1df7028 into main Aug 22, 2024
4 checks passed
@wiseodd wiseodd deleted the fix-typo branch August 22, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants