Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ubuntu 22.04 base image and s6 Overlay v3 #41

Merged
merged 6 commits into from
Oct 6, 2022

Conversation

alexjustesen
Copy link
Owner

@alexjustesen alexjustesen commented Oct 5, 2022

To-do/Issues

Changelog

Changed

  • base image to serversideup/php:beta-8.1-fpm-nginx which uses Ubuntu 22.04 and supports multi-arch, closes Ubuntu 22.04 and multi-arch support #32
  • service file structure to match s6 Overlay v3 suggestions

Build and run

docker build . -t speedtest-tracker
docker run -d --name speedtest-tracker \
    -p 8443:443 \
    -e "DB_CONNECTION=mysql" \
    -e "DB_HOST=mysql" \
    -e "DB_PORT=3306" \
    -e "DB_DATABASE=speedtest_tracker" \
    -e "DB_USERNAME=root" \
    -e "DB_PASSWORD=password" \
    -v /path/to/app/data:/app \
    speedtest-tracker-2204

@alexjustesen alexjustesen added the 🎉 feature New feature or request label Oct 5, 2022
@alexjustesen alexjustesen self-assigned this Oct 5, 2022
@alexjustesen alexjustesen added the 😕 help wanted Extra attention is needed label Oct 5, 2022
@jaydrogers
Copy link
Contributor

I might be able to submit a PR for your app.

Before I do, could you let me know your thoughts on a few questions?

Questions

1. How do you want the local development experience to be?

Do you want spin and everything to be based from Docker? See Financial Freedom for example Laravel repo with Spin →

2. How do you expect deployments to happen?

I assume you want a docker image in Docker Hub (or comparable)? I assume your target market of people are "home labbers" looking to monitor their home internet connection?

@alexjustesen
Copy link
Owner Author

@jaydrogers thanks for the offer!

  1. I've got sail currently as the dev env but I'm open to using spin instead but def not my current priority.
  2. Correct the target is "home labbers" and I'm trying to wrap everything into one container that has a build process to easily get started. Planning on publishing to ghcr and/or Docker Hub

@jaydrogers
Copy link
Contributor

Ahhh okay, sorry I was a confused from earlier. Diving into this more, looks like you have this a lot further along that I initially expected. You can basically ignore my first post 😆

I am taking a look into your issue that you posted earlier (serversideup/docker-php#82). I am seeing if I can replicate it on my end.

I was confused by your COPY .env.docker .env line, but now I think I see your use case for this. Let me do some further testing and I will keep you posted. 👍

@alexjustesen alexjustesen marked this pull request as ready for review October 6, 2022 11:41
@alexjustesen alexjustesen removed the 😕 help wanted Extra attention is needed label Oct 6, 2022
@alexjustesen alexjustesen merged commit 3a836a0 into main Oct 6, 2022
@alexjustesen alexjustesen deleted the ubuntu-2204-base-and-s6-overlay-v3 branch October 6, 2022 11:43
@Drlanderf Drlanderf mentioned this pull request Oct 29, 2023
@rashedobaid rashedobaid mentioned this pull request Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎉 feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ubuntu 22.04 and multi-arch support
2 participants