Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pt_BR Locale files #573

Merged
merged 5 commits into from
May 7, 2023
Merged

pt_BR Locale files #573

merged 5 commits into from
May 7, 2023

Conversation

cacpmw
Copy link
Contributor

@cacpmw cacpmw commented May 5, 2023

I added pt_BR lang to the app. Can you guys develop a feature to let us select language?

@cacpmw cacpmw requested a review from alexjustesen as a code owner May 5, 2023 13:10
@alexjustesen
Copy link
Owner

@cacpmw mind fixing the formatting noted in the tests? Also good suggestion, added as a feature request #574

@cacpmw
Copy link
Contributor Author

cacpmw commented May 6, 2023

@cacpmw mind fixing the formatting noted in the tests? Also good suggestion, added as a feature request #574

Sure, no problem. Is there a way to see the exact lines to be fixed? I saw the report but the message is cropped I cant really read the entire thing

@cacpmw
Copy link
Contributor Author

cacpmw commented May 6, 2023

@alexjustesen I just sent a new commit. Not sure if the test is triggered automagically

@alexjustesen alexjustesen merged commit a26c97e into alexjustesen:main May 7, 2023
ramazansancar added a commit to ramazansancar/alexjustesen_speedtest-tracker that referenced this pull request Dec 29, 2024
upd: pt_BR missing keywords alexjustesen#573 updated
upd: English custom validation attributes added.
upd: package.json updated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants