Merge pull request #476 from alexkappa/fix-action-deployment

Fix action deployment

CHANGELOG.md

@@ -1,3 +1,9 @@
+## 0.24.1
+
+BUG FIXES:
+
+* resource/auth0_action: Secrets would not be created causing deployments to fail ([#473](https://github.com/alexkappa/terraform-provider-auth0/pull/473))
+
 ## 0.24.0
 
 ENHANCEMENTS:

auth0/resource_auth0_action.go

@@ -3,6 +3,7 @@ package auth0
 import (
 	"fmt"
 	"net/http"
+	"strings"
 
 	"github.com/alexkappa/terraform-provider-auth0/auth0/internal/hash"
 	"github.com/hashicorp/terraform-plugin-sdk/helper/resource"
@@ -189,31 +190,36 @@ func updateAction(d *schema.ResourceData, m interface{}) error {
 }
 
 func deployAction(d *schema.ResourceData, m interface{}) error {
+
 	if d.Get("deploy").(bool) == true {
+
 		api := m.(*management.Management)
-		v, err := api.Action.Deploy(d.Id())
-		if err != nil {
-			return err
-		}
-		d.Set("version_id", v.GetID())
 
-		err = resource.Retry(d.Timeout(schema.TimeoutCreate), func() *resource.RetryError {
+		err := resource.Retry(d.Timeout(schema.TimeoutCreate), func() *resource.RetryError {
 
 			a, err := api.Action.Read(d.Id())
 			if err != nil {
 				return resource.NonRetryableError(err)
 			}
 
-			if a.DeployedVersion == nil || a.DeployedVersion.GetID() != v.GetID() {
+			if strings.ToLower(a.GetStatus()) != "built" {
 				return resource.RetryableError(
-					fmt.Errorf("Expected deployed version %q to equal %q",
-						a.DeployedVersion.GetID(),
-						v.GetID()),
+					fmt.Errorf(`Expected action status %q to equal "built"`, a.GetStatus()),
 				)
 			}
 
 			return nil
 		})
+		if err != nil {
+			return fmt.Errorf("Action never reached built state. %w", err)
+		}
+
+		v, err := api.Action.Deploy(d.Id())
+		if err != nil {
+			return err
+		}
+
+		d.Set("version_id", v.GetID())
 	}
 	return nil
 }

example/action/main.tf

@@ -0,0 +1,24 @@
+terraform {
+  required_providers {
+    auth0 = {
+      source = "alexkappa/auth0"
+      version = "0.24.1"
+    }
+  }
+}
+
+provider "auth0" {}
+
+resource "auth0_action" "do" {
+	name = "Test Action ${timestamp()}"
+	supported_triggers {
+		id = "post-login"
+		version = "v2"
+	}
+	code = <<-EOT
+	exports.onContinuePostLogin = async (event, api) => { 
+		console.log(event) 
+	};"
+	EOT
+	deploy = true
+}