Fix small issues in pr

alexkappa · Jan 17, 2022 · c9f2a86 · c9f2a86
1 parent b733bd8
commit c9f2a86
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 12 deletions.
diff --git a/auth0/resource_auth0_client.go b/auth0/resource_auth0_client.go
@@ -487,7 +487,6 @@ func newClient() *schema.Resource {
 						"apple": {
 							Type:     schema.TypeList,
 							Optional: true,
-							Computed: true,
 							MaxItems: 1,
 							Elem: &schema.Resource{
 								Schema: map[string]*schema.Schema{
@@ -501,7 +500,6 @@ func newClient() *schema.Resource {
 						"facebook": {
 							Type:     schema.TypeList,
 							Optional: true,
-							Computed: true,
 							MaxItems: 1,
 							Elem: &schema.Resource{
 								Schema: map[string]*schema.Schema{
@@ -852,19 +850,18 @@ func clientHasChange(c *management.Client) bool {
 	return c.String() != "{}"
 }
 
-func flattenCustomSocialConfiguration(custom_social *management.ClientNativeSocialLogin) []interface{} {
-	// TODO: Implement
-	if custom_social != nil {
+func flattenCustomSocialConfiguration(customSocial *management.ClientNativeSocialLogin) []interface{} {
+	if customSocial != nil {
 		m := make(map[string]interface{})
 
-		if custom_social.Apple != nil {
+		if customSocial.Apple != nil {
 			m["apple"] = map[string]interface{}{
-				"enabled": custom_social.Apple["enabled"],
+				"enabled": customSocial.Apple["enabled"],
 			}
 		}
-		if custom_social.Facebook != nil {
+		if customSocial.Facebook != nil {
 			m["facebook"] = map[string]interface{}{
-				"enabled": custom_social.Facebook["enabled"],
+				"enabled": customSocial.Facebook["enabled"],
 			}
 		}
 

diff --git a/auth0/resource_auth0_client_test.go b/auth0/resource_auth0_client_test.go
@@ -6,11 +6,12 @@ import (
 	"strings"
 	"testing"
 
-	"github.com/alexkappa/terraform-provider-auth0/auth0/internal/random"
 	"github.com/hashicorp/go-multierror"
 	"github.com/hashicorp/terraform-plugin-sdk/helper/resource"
 	"github.com/hashicorp/terraform-plugin-sdk/terraform"
 
+	"github.com/alexkappa/terraform-provider-auth0/auth0/internal/random"
+
 	"gopkg.in/auth0.v5/management"
 )
 
@@ -437,8 +438,8 @@ resource "auth0_client" "my_client" {
       sha256_cert_fingerprints = []
     }
 	ios {
-	  team_id = "9JA89QQLNQ"
-	  app_bundle_identifier = "com.my.bundle.id"
+	  team_id = "1111111111"
+	  app_bundle_identifier = "com.my.auth0.bundle"
 	}
   }
   native_social_login {