Skip to content
This repository has been archived by the owner on Mar 8, 2022. It is now read-only.

Please add the ability to define hook dependencies #296

Closed
epinzur opened this issue Nov 24, 2020 · 6 comments · Fixed by #312
Closed

Please add the ability to define hook dependencies #296

epinzur opened this issue Nov 24, 2020 · 6 comments · Fixed by #312
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed resource/auth0_hook stale

Comments

@epinzur
Copy link

epinzur commented Nov 24, 2020

Description

Auth0 hooks allow the addition of dependencies which are NPM modules that can be used in the javascript. It would be great if we could set the dependencies via the auth0_hook resource.

New or Affected Resource(s)

  • auth0_hook

Potential Terraform Configuration

resource "auth0_hook" "send_password_reset_email" {
  enabled    = true
  name       = "send-password-reset-email"
  trigger_id = "post-user-registration"

   dependencies = {
       auth0 = "2.30.0"
   }

  script = ....
}

References

The management API supports passing dependencies: https://auth0.com/docs/api/management/v2/#!/Hooks/post_hooks

The json snippit for dependencies should look like:

"dependencies": {
      "auth0": "2.30.0"
    },

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
@epinzur epinzur added the enhancement New feature or request label Nov 24, 2020
@alexkappa
Copy link
Owner

Hi @rltvty, indeed it seems we missed this field from this provider. I notice that go-auth0 Hooks already supports dependencies so adding it here should be quite straightforward. Would you feel up for a PR?

@alexkappa alexkappa added good first issue Good for newcomers help wanted Extra attention is needed resource/auth0_hook labels Dec 8, 2020
@woz5999
Copy link
Contributor

woz5999 commented Jan 11, 2021

i also need this. i plan to submit a PR this week.

@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity.
Stale issues will be closed after 5 days if no action is taken. If you
think this issue should not be closed, remove the stale label.

@github-actions github-actions bot added the stale label Mar 13, 2021
@woz5999
Copy link
Contributor

woz5999 commented Mar 13, 2021

@alexkappa this issue is marked as stale; however, there's currently an open PR to address it.

@woz5999
Copy link
Contributor

woz5999 commented Mar 23, 2021

@yvovandoorn this got closed due to inactivity even though we're still working to get that PR finalized.

@yvovandoorn yvovandoorn reopened this Mar 23, 2021
@yvovandoorn
Copy link
Contributor

Reopened @woz5999. Thanks for the heads up.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed resource/auth0_hook stale
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants