Support hook dependencies

[woz5999]

Proposed Changes

• Add support for hook "dependencies"

Fixes #296

Acceptance Test Output

$make testacc TESTS=TestAccHook
==> Checking that code complies with gofmt requirements...
?       github.com/alexkappa/terraform-provider-auth0   [no test files]
=== RUN   TestAccHook
--- PASS: TestAccHook (5.46s)
PASS
coverage: 7.9% of statements
ok      github.com/alexkappa/terraform-provider-auth0/auth0     5.793s  coverage: 7.9% of statements
?       github.com/alexkappa/terraform-provider-auth0/auth0/internal/debug      [no test files]
testing: warning: no tests to run
PASS
coverage: 0.0% of statements
ok      github.com/alexkappa/terraform-provider-auth0/auth0/internal/random     0.277s  coverage: 0.0% of statements [no tests to run]
testing: warning: no tests to run
PASS
coverage: 0.0% of statements
ok      github.com/alexkappa/terraform-provider-auth0/auth0/internal/validation 0.266s  coverage: 0.0% of statements [no tests to run]
?       github.com/alexkappa/terraform-provider-auth0/version   [no test files]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

[woz5999]

@alexkappa are you able to review/merge this?

[woz5999]

@alexkappa would love to get this reviewed and merged

[yvovandoorn]

It looks like the formatting is off? (tabs v space?)

[yvovandoorn]

Hi @woz5999! Could you resolve the merge conflict that was introduced when #262 was merged in?

Both are making updates to the hook test and #262 added quite a few new lines of test code.

I can merge following the updates.

[woz5999]

@yvovandoorn this should be good now.

[yvovandoorn]

Hey @woz5999. This isn't passing my local testing setup:

make testacc TESTS=TestAccHookSecrets                          
==> Checking that code complies with gofmt requirements...
?   	github.com/alexkappa/terraform-provider-auth0	[no test files]
=== RUN   TestAccHookSecrets
    testing.go:705: Step 0 error: Check failed: Check 2/7 error: auth0_hook.my_hook: Attribute 'dependencies.auth0' not found
--- FAIL: TestAccHookSecrets (1.64s)
FAIL
coverage: 8.1% of statements
FAIL	github.com/alexkappa/terraform-provider-auth0/auth0	1.667s
?   	github.com/alexkappa/terraform-provider-auth0/auth0/internal/debug	[no test files]
testing: warning: no tests to run
PASS
coverage: 0.0% of statements
ok  	github.com/alexkappa/terraform-provider-auth0/auth0/internal/random	0.023s	coverage: 0.0% of statements [no tests to run]
testing: warning: no tests to run
PASS
coverage: 0.0% of statements
ok  	github.com/alexkappa/terraform-provider-auth0/auth0/internal/validation	0.018s	coverage: 0.0% of statements [no tests to run]
?   	github.com/alexkappa/terraform-provider-auth0/version	[no test files]
FAIL
make: *** [testacc] Error 1

It looks like

resource.TestCheckResourceAttr("auth0_hook.my_hook", "dependencies.auth0", "2.30.0"),

should be added to L64 in auth0/resource_auth0_hook_test.go

and

  dependencies = {
    auth0 = "2.30.0"
  }

to L93-95 in auth0/resource_auth0_hook_test.go

This way it passes the initial and diff check.

[woz5999]

@yvovandoorn sorry about that. got those added.

[yvovandoorn]

👍 LGTM

[galkin]

@yvovandoorn, do you have new release estimate?

[yvovandoorn]

@galkin probably in the coming days. I hope to incorporate #321 but its dependent on go-auth0/auth0#187. That said, if its taking too long, I'll talk with @alexkappa to push out a release earlier.

Thanks for your patience on this!!

[yvovandoorn]

@galkin released! https://github.com/alexkappa/terraform-provider-auth0/releases/tag/v0.20.0