Add the new identifier_first argument to prompts

[kpurdon]

Proposed Changes

Adds the new identifier_first argument to prompts. I will update the terraform provider as well once this lands and is tagged.

https://support.auth0.com/notifications/5fff0ab3f28427000a77941e

Acceptance Test Output

kpurdon@syndio: ~/.../kpurdon/auth0 go test ./... -v -run TestPrompt
testing: warning: no tests to run
PASS
ok  	gopkg.in/auth0.v5	(cached) [no tests to run]
testing: warning: no tests to run
PASS
ok  	gopkg.in/auth0.v5/internal/client	(cached) [no tests to run]
testing: warning: no tests to run
PASS
ok  	gopkg.in/auth0.v5/internal/tag	(cached) [no tests to run]
testing: warning: no tests to run
PASS
ok  	gopkg.in/auth0.v5/internal/testing/expect	(cached) [no tests to run]
=== RUN   TestPrompt
=== RUN   TestPrompt/Read
    prompt_test.go:14: {
          "universal_login_experience": "classic"
        }
=== RUN   TestPrompt/Update
    prompt_test.go:48: {
          "universal_login_experience": "new",
          "identifier_first": true
        }
--- PASS: TestPrompt (1.67s)
    --- PASS: TestPrompt/Read (1.24s)
    --- PASS: TestPrompt/Update (0.42s)
PASS
ok  	gopkg.in/auth0.v5/management	1.956s

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

[kpurdon]

cc @alexkappa

[kpurdon]

Hi @alexkappa checking in here, would love to get this and the terraform PR reviewed soon.

[paddycarey]

Should this be *bool to follow the convention of fields in all the other structs? It would then better deal with null responses from the API.

Looks like the existing UniversalLoginExperience field in this struct should be updated too, but we can do that in another PR and discuss first (it'd be a breaking change).

If updated to *bool you should run go generate ./... to generate an accessor for the field.

[kpurdon]

Updated to *bool. I don't think the string field needs to be a pointer since an empty string will get handled by omitempty were false would not.

As a side note after running generate it looks like it generated a bunch of things from other PRs. It would be great to run everything up until the tests on every PR to ensure fmt/generate is good before merging to master.

[kpurdon]

@paddycarey anything else I can do here before merging? Once this is merged/released I can update the terrafrom side. Thanks!

[kpurdon]

@alexkappa @paddycarey what can I do to get this merged?

[kpurdon]

@alexkappa please let me know what we can do here.

[yvovandoorn]

@kpurdon With the merging of #200, the generated accessors are conflicting. Could you re-run go generate and commit? I'll commit to getting this merged afterwards.

[kpurdon]

@yvovandoorn updated as requested. Thanks!

[yvovandoorn]

Hey @kpurdon. Thanks for that!

Unfortunately the test for it isn't passing locally:

go test ./... -v -run TestPrompt                                                     ✔ │ 08:00:05  
testing: warning: no tests to run
PASS
ok  	gopkg.in/auth0.v5	0.016s [no tests to run]
testing: warning: no tests to run
PASS
ok  	gopkg.in/auth0.v5/internal/client	0.010s [no tests to run]
testing: warning: no tests to run
PASS
ok  	gopkg.in/auth0.v5/internal/tag	0.015s [no tests to run]
testing: warning: no tests to run
PASS
ok  	gopkg.in/auth0.v5/internal/testing/expect	0.018s [no tests to run]
=== RUN   TestPrompt
=== RUN   TestPrompt/Read
    prompt_test.go:14: {
          "universal_login_experience": "new",
          "identifier_first": true
        }
=== RUN   TestPrompt/Update
    prompt_test.go:49: unexpected output. have 0xc00001c273, expected 0xc0000a2349
    prompt_test.go:51: {
          "universal_login_experience": "new",
          "identifier_first": true
        }
--- FAIL: TestPrompt (0.74s)
    --- PASS: TestPrompt/Read (0.45s)
    --- FAIL: TestPrompt/Update (0.29s)
FAIL
FAIL	gopkg.in/auth0.v5/management	0.749s
FAIL

Which got me to think on how you're testing. I see that you've imported the json library. Would you consider adopting the way booleans & strings are tested in other API endpoints (e.g. hook_test.go is a reasonable one to look at).

Rather than doing:

	falseV := false
	trueV := true

You can use auth0.Bool(false) and auth0.Bool(true).

Than rather than using literal strings (e.g. UniversalLoginExperience: "classic",) you'd use something like UniversalLoginExperience: auth0.String("classic"),.

Then you can use "gopkg.in/auth0.v5/internal/testing/expect" library and reduce the expects to something (like):

expect.Expect(t, r["UniversalLoginExperience"], "new")

which would be consistent with the other tests in this SDK.

[kpurdon]

@yvovandoorn updated the tests and confirmed they are passing locally

kpurdon@syndio: ~/.../kpurdon/auth0 go test ./... -v -run TestPrompt
testing: warning: no tests to run
PASS
ok  	gopkg.in/auth0.v5	(cached) [no tests to run]
testing: warning: no tests to run
PASS
ok  	gopkg.in/auth0.v5/internal/client	(cached) [no tests to run]
testing: warning: no tests to run
PASS
ok  	gopkg.in/auth0.v5/internal/tag	(cached) [no tests to run]
testing: warning: no tests to run
PASS
ok  	gopkg.in/auth0.v5/internal/testing/expect	(cached) [no tests to run]
=== RUN   TestPrompt
--- PASS: TestPrompt (2.69s)
PASS
ok  	gopkg.in/auth0.v5/management	(cached)

[yvovandoorn]

💥 🚀