readXXX functions should fully populate resource objects

[dancrumb]

Right now, implementations of readXXX only partially populate the ResourceData objects.

It's tedious work, to be sure, but I think they should really be fully populating them. See, for example: https://github.com/terraform-providers/terraform-provider-aws/blob/master/aws/resource_aws_api_gateway_integration_response.go#L152

• Clients (Applications)
• Client Grants
• Connections
• Custom Domains
• Resource Servers (APIs)
• Rules
• Rules Configs

[alexkappa]

Yes, absolutely. We should do this to be in line with other providers and be consistent.

[dancrumb]

I'm working on the Client resource today

[alexkappa]

Sweet, thanks Dan! I can start from the bottom of the list.

…

On Tue, May 29, 2018 at 3:39 PM Dan Rumney ***@***.***> wrote: I'm working on the Client resource today — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#7 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABJffz6fjzd4VLDzfRlW7KBA678ZEOolks5t3U-pgaJpZM4UQuAP> .

-- *Alex Kalyvitis* CTO Yieldr Labs BV Stadhouderskade 85 | 1073 AT Amsterdam | The Netherlands O: +31 (0) 85 877 1018 | M: +31 6 23 41 21 91 Li: linkedin.com/yieldr <https://rb.tc/MF9#https://www.linkedin.com/company/yd-group-bv?trk=tyah&trkInfo=tarId%3A1401265838181%2Ctas%3Ayieldr%2Cidx%3A2-1-2> | Tw: @yieldr <https://rb.tc/MF0#https://twitter.com/Yieldr> | Fb: Yieldr <https://rb.tc/MFA#https://www.facebook.com/yieldr> *Yieldr UK Ltd (HQ)*PLC 09002780 1 Fetter Lane | EC4A 1BR | United Kingdom <http://www.yieldr.com/>

[dancrumb]

First pass at Client resource in #8

[dancrumb]

At long last, the PR is complete :)

[alexkappa]

Thanks for the help on this @dancrumb !

[dancrumb]

Thanks for your patience! This is the first time I've really written any Go, so it was a bit of a slog. but I'm excited to have this functionality!