Skip to content
This repository has been archived by the owner on Mar 8, 2022. It is now read-only.

Fix connection display name #304

Merged
merged 2 commits into from
Apr 6, 2021
Merged

Conversation

alexkappa
Copy link
Owner

Proposed Changes

  • Add display_name to auth0_connection resource.

Fixes #288

Acceptance Test Output

$ make testacc TESTS=TestAccConnectionSAML                                                                                                         [18:52:07]
==> Checking that code complies with gofmt requirements...
?       github.com/alexkappa/terraform-provider-auth0   [no test files]
=== RUN   TestAccConnectionSAML
--- PASS: TestAccConnectionSAML (2.08s)
PASS
coverage: 10.6% of statements
ok      github.com/alexkappa/terraform-provider-auth0/auth0     2.377s  coverage: 10.6% of statements

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

@github-actions
Copy link

This PR has become stale as it has been open 30 days with no activity.
Stale PRs will be closed after 5 days if no action is taken. If you
think this PR should not be closed, remove the stale label.

@github-actions github-actions bot added the stale label Feb 10, 2021
@github-actions github-actions bot closed this Feb 17, 2021
@rabidscorpio
Copy link

@alexkappa Is there a reason this was never merged? This would be really nice to have instead of having to edit the connection manually.

@rabidscorpio
Copy link

@yvovandoorn This PR was also only closed for being stale, can you please look at this?

@yvovandoorn yvovandoorn reopened this Apr 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display Name not being set when creating auth0_connection resources.
3 participants