Skip to content
This repository has been archived by the owner on Mar 8, 2022. It is now read-only.

Fix client mobile #305

Merged
merged 3 commits into from
Dec 11, 2020
Merged

Fix client mobile #305

merged 3 commits into from
Dec 11, 2020

Conversation

alexkappa
Copy link
Owner

Proposed Changes

  • Fix handling of mobile.android.sha256_cert_fingerprints to be a slice of strings
  • Fix incorrect handling of mobile.ios.team_id
  • Fix incorrect handling of mobile.ios.app_bundle_identifier

Fixes #253

Acceptance Test Output

$ make testacc TESTS=TestAccClient                                                                                                       [16:44:23]
==> Checking that code complies with gofmt requirements...
go: downloading gopkg.in/auth0.v5 v5.3.0
?       github.com/alexkappa/terraform-provider-auth0   [no test files]
=== RUN   TestAccClientGrant
--- PASS: TestAccClientGrant (4.65s)
=== RUN   TestAccClient
--- PASS: TestAccClient (0.86s)
=== RUN   TestAccClientZeroValueCheck
--- PASS: TestAccClientZeroValueCheck (2.12s)
=== RUN   TestAccClientRotateSecret
--- PASS: TestAccClientRotateSecret (1.48s)
=== RUN   TestAccClientInitiateLoginUri
--- PASS: TestAccClientInitiateLoginUri (0.02s)
=== RUN   TestAccClientJwtScopes
--- PASS: TestAccClientJwtScopes (1.68s)
PASS
coverage: 24.0% of statements
ok      github.com/alexkappa/terraform-provider-auth0/auth0     11.241s coverage: 24.0% of statements

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

@alexkappa alexkappa merged commit e3c4790 into master Dec 11, 2020
@yvovandoorn yvovandoorn deleted the fix-client-mobile branch March 24, 2021 14:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting an auth0_client android sha256_cert_fingerprints parameter causes terraform to crash
1 participant