Skip to content
This repository has been archived by the owner on Mar 8, 2022. It is now read-only.

Hook up 'windowslive' social connection type #335

Merged
merged 1 commit into from
Mar 21, 2021

Conversation

mamacdon
Copy link

Fixes #320

Proposed Changes

This hooks up the windowslive social connection that was commented out.

I've tested it against my Auth0 tenant, and it seems to correctly provision and configure a Windows Live connection – i.e. "Try Connection" works after applying the plan shown below. However, I was kind of guessing my way through this, so any feedback would be welcome.

Exampleterraform plan output

# module.auth0_deployment.module.identity_providers_social.auth0_connection.windowslive will be created
+ resource "auth0_connection" "windowslive" {
    + enabled_clients      = [
        + "……",
        + "……",
      ]
    + id                   = (known after apply)
    + is_domain_connection = (known after apply)
    + name                 = "windowslive"
    + realms               = (known after apply)
    + strategy             = "windowslive"
    + strategy_version     = (known after apply)
    + options {
        + client_id                = "73831016-83b9-4215-a7a5-5be48677e743"
        + client_secret            = (sensitive value)
        + password_policy          = (known after apply)
        + scopes                   = [
            + "graph_user",
            + "signin",
          ]
        + set_user_root_attributes = (known after apply)
        + strategy_version         = 2
        + password_history {
            + enable = (known after apply)
            + size   = (known after apply)
          }
      }
  }

Acceptance Test Output

$ make testacc TESTS=TestAccConnectionWindowslive
==> Checking that code complies with gofmt requirements...
?   	github.com/alexkappa/terraform-provider-auth0	[no test files]
=== RUN   TestAccConnectionWindowslive
--- PASS: TestAccConnectionWindowslive (2.57s)
PASS
coverage: 11.5% of statements
ok  	github.com/alexkappa/terraform-provider-auth0/auth0	3.144s	coverage: 11.5% of statements
?   	github.com/alexkappa/terraform-provider-auth0/auth0/internal/debug	[no test files]
testing: warning: no tests to run
PASS
coverage: 0.0% of statements
ok  	github.com/alexkappa/terraform-provider-auth0/auth0/internal/random	0.385s	coverage: 0.0% of statements [no tests to run]
testing: warning: no tests to run
PASS
coverage: 0.0% of statements
ok  	github.com/alexkappa/terraform-provider-auth0/auth0/internal/validation	0.949s	coverage: 0.0% of statements [no tests to run]
?   	github.com/alexkappa/terraform-provider-auth0/version	[no test files]

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

@yvovandoorn
Copy link
Contributor

Thanks for the contribution @mamacdon! I've locally tested the changes and verified against my Auth0 tenant.

Appreciate that your test also had an update connection component to it :-).

@yvovandoorn yvovandoorn merged commit 1cd234a into alexkappa:master Mar 21, 2021
@mamacdon mamacdon deleted the windowslive branch March 22, 2021 14:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

windowslive auth0_connection misconfigures resources
3 participants