This repository has been archived by the owner on Mar 8, 2022. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 149
Feature/adding auth0 guardian #371
Merged
yvovandoorn
merged 17 commits into
alexkappa:master
from
apamildner:feature/adding-auth0-guardian
Apr 19, 2021
Merged
Feature/adding auth0 guardian #371
yvovandoorn
merged 17 commits into
alexkappa:master
from
apamildner:feature/adding-auth0-guardian
Apr 19, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apamildner
force-pushed
the
feature/adding-auth0-guardian
branch
from
April 15, 2021 13:59
b5c0cb7
to
756838e
Compare
apamildner
changed the title
[DRAFT] Feature/adding auth0 guardian
Feature/adding auth0 guardian
Apr 15, 2021
apamildner
changed the title
Feature/adding auth0 guardian
[DRAFT]Feature/adding auth0 guardian
Apr 15, 2021
apamildner
force-pushed
the
feature/adding-auth0-guardian
branch
from
April 19, 2021 06:20
44290ee
to
3156fd7
Compare
I only add support for phone since this is what we need.
Added documentation for guardian
…erged into master
apamildner
force-pushed
the
feature/adding-auth0-guardian
branch
from
April 19, 2021 06:30
070f96f
to
136bf1d
Compare
apamildner
changed the title
[DRAFT]Feature/adding auth0 guardian
Feature/adding auth0 guardian
Apr 19, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the
auth0_guardian
resource which can be used to customize the MFA options. I've built it in a way that should make it easy enough to add the other factors at some point.Worth noting is that if the phone block is present, it will be enabled, while if it is gone it will be disabled.
I.e this would mean phone is enabled:
while this would mean phone is disabled (which would make more sense once more options than phone is introduced):
Proposed Changes
Related to #367. This is a reworked PR since the last one had major flaws in Read which was detected after merge, hence the revert #370.
Fixes #286
Acceptance Test Output
Community Note