Skip to content
This repository has been archived by the owner on Mar 8, 2022. It is now read-only.

Updated protocol binding to use all capitals #449

Merged
merged 3 commits into from
Jan 25, 2022
Merged

Updated protocol binding to use all capitals #449

merged 3 commits into from
Jan 25, 2022

Conversation

jackton1
Copy link
Contributor

@jackton1 jackton1 commented Sep 22, 2021 •
edited
Loading

Proposed Changes

  • Resolves empty selected protocol binding in Auth0 using urn:oasis:names:tc:SAML:2.0:bindings:HTTP-Post

Screen Shot 2021-09-22 at 6 58 53 PM

Acceptance Test Output

$ make testacc TESTS=TestAccXXX

...

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

@alexkappa

willvedd
willvedd approved these changes Jan 25, 2022
View reviewed changes
Copy link
Collaborator

@willvedd willvedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm that this binding declaration should have the HTTP method in all caps. Thanks for addressing!

@willvedd willvedd merged commit 97a1133 into alexkappa:master Jan 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@willvedd willvedd willvedd approved these changes

Assignees
No one assigned
Labels
resource/auth0_connection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jackton1 @willvedd