Build: re-build the cache for every commit #433

alexklibisz · 2022-09-26T11:21:39Z

Related Issue

Re-build the cache for every commit by keying on the commit name instead of the branch name. The previous strategy used the branch name in the key. But, if an entry already exists in the cache, it won't be overridden. Github will just continue pulling the older entry. That means it keeps pulling the 7-day old master-branch entry when running for a push to master, and keeps pulling the first entry from a given branch when running for a PR. To solve this, we can key on the commit sha, with a fallback to the previous commit sha. This will create more churn in the cache, but it doesn't really matter since Github cleans all of that up.

How was it validated?

alexklibisz added 7 commits September 26, 2022 07:21

Build: re-use cache correctly

7e1297f

Try better keys

5f9d03d

fallback to old master key to save time

755293b

Try again without master key

57e9f58

Use the same caching strategy in other jobs

f2e7f09

Echo the keys

891c4af

Update cache in release workflow

d78348b

alexklibisz changed the title ~~Build: re-use cache correctly~~ Build: re-build the cache for every commit Sep 26, 2022

alexklibisz marked this pull request as ready for review September 26, 2022 12:05

alexklibisz merged commit 93550ce into master Sep 26, 2022

alexklibisz deleted the test-gh-actions-cache-2 branch September 26, 2022 12:05