Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move init to the main package #28

Merged
merged 1 commit into from
Jun 13, 2023

Conversation

ldez
Copy link
Contributor

@ldez ldez commented Jun 8, 2023

The init function modifies the global variable build.Default but this impacts golangci-lint and Kubernetes.

https://gophers.slack.com/archives/CS0TBRKPC/p1686144370506279

Co-authored-by: Patrick Ohly <patrick.ohly@intel.com>
@ldez
Copy link
Contributor Author

ldez commented Jun 13, 2023

friendly ping @alexkohler

@alexkohler
Copy link
Owner

Missed this, thanks for the ping! Please let me know if you need a new tag created.

@alexkohler alexkohler merged commit 564f756 into alexkohler:master Jun 13, 2023
@ldez ldez deleted the fix/move-init branch June 13, 2023 22:25
@ldez
Copy link
Contributor Author

ldez commented Jun 13, 2023

@alexkohler Thank you, if you could tag it that would be great.

@alexkohler
Copy link
Owner

Done - tagged in v2.0.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants