Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nom needs an upgrade #3

Closed
snaggen opened this issue Mar 10, 2023 · 2 comments
Closed

Nom needs an upgrade #3

snaggen opened this issue Mar 10, 2023 · 2 comments

Comments

@snaggen
Copy link

snaggen commented Mar 10, 2023

Currently rust compiler complains about nom 4.2.3 using constructs that will be errors in future releases, so I guess nom needs an upgrade. However, I'm not comfortable enough in either stomp or nom to easily do this myself since nom have removed the use of macros so some code needs some minor rewrite.
@snaggen
Copy link
Author

snaggen commented May 25, 2023

I noticed that there are fixes for this in both the nom 5 and 6 branches, so it might be easiest to first target nom 5, since the macros should still be there. However, when I tried, some macros were removed and needed to be replaced, and I don't have access to a activemq development system to test on right now.

@snaggen
Copy link
Author

snaggen commented Dec 31, 2023

#13 fixed this

@snaggen snaggen closed this as completed Dec 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@snaggen