-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade to nom7 #13
upgrade to nom7 #13
Conversation
I have made some tests sending messages, and it seems to work as expected! I realize that I don't have any applications in rust that listens to messages, so I have not tested that. |
@zuisong I suggest that we, in the documentation for connect, mention something like. "If no specific virtualhost is desired, it is recommended to set this to the same as the host name that the socket was established against (i.e, the same as the server address)." |
Looks good. I have had this running on a system for the last day with no issues. |
hey if you feel like taking over this project I would be glad to transfer it. it was useful for a while, but as you can see I don't really have time for it anymore. |
Thank you for offering me the opportunity, but I'm sorry, I don't have any intention to take over this project at the moment. I hope you can find someone suitable to continue maintaining it. If you have any other questions or need assistance, I would be happy to help. |
Thank you, i'll try to make some time to go over the changes! |
@zuisong can you please run rust fmt on your fork? Ill restart the pipeline after |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #13 +/- ##
==========================================
- Coverage 60.17% 59.86% -0.31%
==========================================
Files 3 3
Lines 585 578 -7
==========================================
- Hits 352 346 -6
+ Misses 233 232 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexkunde
I have fixed the code. Can you please rerun the pipeline?
Thank you for contributing, especially for moving this to nom7! |
host
andserver address
.In the STOMP protocol specification, "host" and "server-address" are different concepts.